Title: [230937] trunk
- Revision
- 230937
- Author
- [email protected]
- Date
- 2018-04-23 18:07:57 -0700 (Mon, 23 Apr 2018)
Log Message
[GTK] check target looks broken
https://bugs.webkit.org/show_bug.cgi?id=184407
Reviewed by Carlos Garcia Campos.
It's pretty clear that nobody has been using check for a long time.
We got rid of check-for-webkitdom-api-breaks a long time ago, when we stopped autogenerating
the DOM API, but it's still used in the check target. Fix this.
Also, the check target for some reason runs itself from the Source subdirectory of the
builddir, but the test script expects to be run from the toplevel build directory. Fix this
too.
Add VERBATIM for good measure.
* Source/PlatformGTK.cmake:
Modified Paths
Diff
Modified: trunk/ChangeLog (230936 => 230937)
--- trunk/ChangeLog 2018-04-24 01:07:06 UTC (rev 230936)
+++ trunk/ChangeLog 2018-04-24 01:07:57 UTC (rev 230937)
@@ -1,3 +1,23 @@
+2018-04-23 Michael Catanzaro <[email protected]>
+
+ [GTK] check target looks broken
+ https://bugs.webkit.org/show_bug.cgi?id=184407
+
+ Reviewed by Carlos Garcia Campos.
+
+ It's pretty clear that nobody has been using check for a long time.
+
+ We got rid of check-for-webkitdom-api-breaks a long time ago, when we stopped autogenerating
+ the DOM API, but it's still used in the check target. Fix this.
+
+ Also, the check target for some reason runs itself from the Source subdirectory of the
+ builddir, but the test script expects to be run from the toplevel build directory. Fix this
+ too.
+
+ Add VERBATIM for good measure.
+
+ * Source/PlatformGTK.cmake:
+
2018-04-20 Daniel Bates <[email protected]>
Unreviewed, rolling out r230117.
Modified: trunk/Source/PlatformGTK.cmake (230936 => 230937)
--- trunk/Source/PlatformGTK.cmake 2018-04-24 01:07:06 UTC (rev 230936)
+++ trunk/Source/PlatformGTK.cmake 2018-04-24 01:07:57 UTC (rev 230937)
@@ -53,7 +53,8 @@
add_custom_target(check
COMMAND ${TOOLS_DIR}/Scripts/run-gtk-tests
- COMMAND ${TOOLS_DIR}/gtk/check-for-webkitdom-api-breaks
+ WORKING_DIRECTORY "${CMAKE_BINARY_DIR}"
+ VERBATIM
)
if (DEVELOPER_MODE)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
