Title: [230939] trunk/LayoutTests
- Revision
- 230939
- Author
- [email protected]
- Date
- 2018-04-23 19:30:20 -0700 (Mon, 23 Apr 2018)
Log Message
Unreviewed, fix a few tests that became flaky after r230919.
* fast/events/beforeunload-alert-handled-keydown.html:
* fast/events/beforeunload-alert-no-user-interaction.html:
* fast/events/beforeunload-alert-user-interaction.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (230938 => 230939)
--- trunk/LayoutTests/ChangeLog 2018-04-24 02:03:27 UTC (rev 230938)
+++ trunk/LayoutTests/ChangeLog 2018-04-24 02:30:20 UTC (rev 230939)
@@ -1,3 +1,11 @@
+2018-04-23 Chris Dumez <[email protected]>
+
+ Unreviewed, fix a few tests that became flaky after r230919.
+
+ * fast/events/beforeunload-alert-handled-keydown.html:
+ * fast/events/beforeunload-alert-no-user-interaction.html:
+ * fast/events/beforeunload-alert-user-interaction.html:
+
2018-04-23 Commit Queue <[email protected]>
Unreviewed, rolling out r230921, r230923, r230924, r230932,
Modified: trunk/LayoutTests/fast/events/beforeunload-alert-handled-keydown.html (230938 => 230939)
--- trunk/LayoutTests/fast/events/beforeunload-alert-handled-keydown.html 2018-04-24 02:03:27 UTC (rev 230938)
+++ trunk/LayoutTests/fast/events/beforeunload-alert-handled-keydown.html 2018-04-24 02:30:20 UTC (rev 230939)
@@ -20,8 +20,8 @@
setTimeout(function() {
shouldBeEqualToString("testInput.value", "a");
+ testFrame._onload_ = finishJSTest;
testFrame.src = ""
- setTimeout(finishJSTest, 0);
}, 0);
};
</script>
Modified: trunk/LayoutTests/fast/events/beforeunload-alert-no-user-interaction.html (230938 => 230939)
--- trunk/LayoutTests/fast/events/beforeunload-alert-no-user-interaction.html 2018-04-24 02:03:27 UTC (rev 230938)
+++ trunk/LayoutTests/fast/events/beforeunload-alert-no-user-interaction.html 2018-04-24 02:30:20 UTC (rev 230939)
@@ -12,8 +12,8 @@
return "FAIL: a beforeunload alert was shown even though the user did not interact with the page.";
};
setTimeout(function() {
+ testFrame._onload_ = finishJSTest;
testFrame.src = ""
- setTimeout(finishJSTest, 0);
}, 0);
};
</script>
Modified: trunk/LayoutTests/fast/events/beforeunload-alert-user-interaction.html (230938 => 230939)
--- trunk/LayoutTests/fast/events/beforeunload-alert-user-interaction.html 2018-04-24 02:03:27 UTC (rev 230938)
+++ trunk/LayoutTests/fast/events/beforeunload-alert-user-interaction.html 2018-04-24 02:30:20 UTC (rev 230939)
@@ -17,8 +17,8 @@
if (window.eventSender)
eventSender.keyDown("a");
setTimeout(function() {
+ testFrame._onload_ = finishJSTest;
testFrame.src = ""
- setTimeout(finishJSTest, 0);
}, 0);
};
</script>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
