Title: [230949] trunk
Revision
230949
Author
[email protected]
Date
2018-04-24 01:06:56 -0700 (Tue, 24 Apr 2018)

Log Message

[WPE] Remove libgbm dependency
https://bugs.webkit.org/show_bug.cgi?id=184906

Reviewed by Carlos Garcia Campos.

.:

Remove the libgbm CMake search module. It's not necessary anymore
after r230562.

* Source/cmake/FindLibGBM.cmake: Removed.

Tools:

Stop searching for libgbm, using its compiler flags for the
HeadlessViewBackend compilation and linking against the .so object.
This is not necessary anymore after r230562 switched to a different
backend implementation for testing.

* wpe/HeadlessViewBackend/CMakeLists.txt:
* wpe/install-dependencies:

Modified Paths

Removed Paths

Diff

Modified: trunk/ChangeLog (230948 => 230949)


--- trunk/ChangeLog	2018-04-24 08:02:10 UTC (rev 230948)
+++ trunk/ChangeLog	2018-04-24 08:06:56 UTC (rev 230949)
@@ -1,3 +1,15 @@
+2018-04-24  Zan Dobersek  <[email protected]>
+
+        [WPE] Remove libgbm dependency
+        https://bugs.webkit.org/show_bug.cgi?id=184906
+
+        Reviewed by Carlos Garcia Campos.
+
+        Remove the libgbm CMake search module. It's not necessary anymore
+        after r230562.
+
+        * Source/cmake/FindLibGBM.cmake: Removed.
+
 2018-04-23  Michael Catanzaro  <[email protected]>
 
         [GTK] check target looks broken

Deleted: trunk/Source/cmake/FindLibGBM.cmake (230948 => 230949)


--- trunk/Source/cmake/FindLibGBM.cmake	2018-04-24 08:02:10 UTC (rev 230948)
+++ trunk/Source/cmake/FindLibGBM.cmake	2018-04-24 08:06:56 UTC (rev 230949)
@@ -1,47 +0,0 @@
-# - Try to find gbm.
-# Once done, this will define
-#
-#  LIBGBM_INCLUDE_DIRS - the gbm include directories
-#  LIBGBM_LIBRARIES - link these to use gbm.
-#
-# Copyright (C) 2015 Igalia S.L.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-# 1.  Redistributions of source code must retain the above copyright
-#     notice, this list of conditions and the following disclaimer.
-# 2.  Redistributions in binary form must reproduce the above copyright
-#     notice, this list of conditions and the following disclaimer in the
-#     documentation and/or other materials provided with the distribution.
-#
-# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER AND ITS CONTRIBUTORS ``AS
-# IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
-# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR ITS
-# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
-# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
-# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
-# OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
-# WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
-# OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
-# ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-find_package(PkgConfig)
-pkg_check_modules(PC_LIBGBM gbm)
-
-find_path(LIBGBM_INCLUDE_DIRS
-    NAMES gbm.h
-    HINTS ${PC_LIBGBM_INCLUDE_DIRS} ${PC_LIBGBM_INCUDEDIR}
-)
-
-find_library(LIBGBM_LIBRARIES
-    NAMES gbm
-    HINTS ${PC_LIBGBM_LIBRARY_DIRS} ${PC_LIBGBM_LIBDIR}
-)
-
-include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(LibGBM REQUIRED_VARS LIBGBM_LIBRARIES
-                                  FOUND_VAR LIBGBM_FOUND)
-
-mark_as_advanced(LIBGBM_INCLUDE_DIRS LIBGBM_LIBRARIES)

Modified: trunk/Tools/ChangeLog (230948 => 230949)


--- trunk/Tools/ChangeLog	2018-04-24 08:02:10 UTC (rev 230948)
+++ trunk/Tools/ChangeLog	2018-04-24 08:06:56 UTC (rev 230949)
@@ -1,3 +1,18 @@
+2018-04-24  Zan Dobersek  <[email protected]>
+
+        [WPE] Remove libgbm dependency
+        https://bugs.webkit.org/show_bug.cgi?id=184906
+
+        Reviewed by Carlos Garcia Campos.
+
+        Stop searching for libgbm, using its compiler flags for the
+        HeadlessViewBackend compilation and linking against the .so object.
+        This is not necessary anymore after r230562 switched to a different
+        backend implementation for testing.
+
+        * wpe/HeadlessViewBackend/CMakeLists.txt:
+        * wpe/install-dependencies:
+
 2018-04-23  Carlos Garcia Campos  <[email protected]>
 
         [GLIB] Make it possible to use a different timeout for slow test cases in GLib tests

Modified: trunk/Tools/wpe/HeadlessViewBackend/CMakeLists.txt (230948 => 230949)


--- trunk/Tools/wpe/HeadlessViewBackend/CMakeLists.txt	2018-04-24 08:02:10 UTC (rev 230948)
+++ trunk/Tools/wpe/HeadlessViewBackend/CMakeLists.txt	2018-04-24 08:06:56 UTC (rev 230949)
@@ -1,4 +1,3 @@
-find_package(LibGBM REQUIRED)
 find_package(WPEBackend-fdo REQUIRED)
 
 set(WPEHeadlessViewBackend_SOURCES
@@ -8,7 +7,6 @@
 set(WPEHeadlessViewBackend_SYSTEM_INCLUDE_DIRECTORIES
     ${CAIRO_INCLUDE_DIRS}
     ${GLIB_INCLUDE_DIRS}
-    ${LIBGBM_INCLUDE_DIRS}
     ${WPEBACKEND_FDO_INCLUDE_DIRS}
 )
 
@@ -15,7 +13,6 @@
 set(WPEHeadlessViewBackend_LIBRARIES
     ${CAIRO_LIBRARIES}
     ${GLIB_LIBRARIES}
-    ${LIBGBM_LIBRARIES}
     ${WPEBACKEND_FDO_LIBRARIES}
 )
 

Modified: trunk/Tools/wpe/install-dependencies (230948 => 230949)


--- trunk/Tools/wpe/install-dependencies	2018-04-24 08:02:10 UTC (rev 230948)
+++ trunk/Tools/wpe/install-dependencies	2018-04-24 08:06:56 UTC (rev 230949)
@@ -109,7 +109,6 @@
         gsettings-desktop-schemas-dev \
         libegl1-mesa-dev \
         libexpat1-dev \
-        libgbm-dev \
         libgles2-mesa-dev \
         libluajit-5.1-dev \
         libmount-dev \
@@ -301,7 +300,6 @@
         libXrandr-devel \
         luajit \
         luajit-devel \
-        mesa-libgbm-devel \
         mesa-libGLES-devel \
         mesa-libEGL-devel \
         opus-devel \
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to