Title: [230954] trunk/Source/WebKit
- Revision
- 230954
- Author
- [email protected]
- Date
- 2018-04-24 08:26:42 -0700 (Tue, 24 Apr 2018)
Log Message
REGRESSION(r230950): Faulty commit sequencing in CoordinatedGraphicsScene
https://bugs.webkit.org/show_bug.cgi?id=184917
Reviewed by Michael Catanzaro.
After r230950, current animation state for a given layer is also taken
into account when determining whether or not the layer requires a
backing store. For that to work properly, all the animation state has
to be updated before the backing store work. This patch changes the
order of helper method invocations in
CoordinatedGraphicsScene::setLayerState() to address that.
* Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::CoordinatedGraphicsScene::setLayerState):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (230953 => 230954)
--- trunk/Source/WebKit/ChangeLog 2018-04-24 11:01:49 UTC (rev 230953)
+++ trunk/Source/WebKit/ChangeLog 2018-04-24 15:26:42 UTC (rev 230954)
@@ -1,5 +1,22 @@
2018-04-24 Zan Dobersek <[email protected]>
+ REGRESSION(r230950): Faulty commit sequencing in CoordinatedGraphicsScene
+ https://bugs.webkit.org/show_bug.cgi?id=184917
+
+ Reviewed by Michael Catanzaro.
+
+ After r230950, current animation state for a given layer is also taken
+ into account when determining whether or not the layer requires a
+ backing store. For that to work properly, all the animation state has
+ to be updated before the backing store work. This patch changes the
+ order of helper method invocations in
+ CoordinatedGraphicsScene::setLayerState() to address that.
+
+ * Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
+ (WebKit::CoordinatedGraphicsScene::setLayerState):
+
+2018-04-24 Zan Dobersek <[email protected]>
+
[CoordGraphics] Remove unused fixed layout functionality
https://bugs.webkit.org/show_bug.cgi?id=184908
Modified: trunk/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp (230953 => 230954)
--- trunk/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp 2018-04-24 11:01:49 UTC (rev 230953)
+++ trunk/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp 2018-04-24 15:26:42 UTC (rev 230954)
@@ -239,15 +239,14 @@
}
}
- prepareContentBackingStore(layer, commitScope);
-
// Apply Operations.
setLayerChildrenIfNeeded(layer, layerState);
+ setLayerFiltersIfNeeded(layer, layerState);
+ setLayerAnimationsIfNeeded(layer, layerState);
+ prepareContentBackingStore(layer, commitScope);
createTilesIfNeeded(layer, layerState);
removeTilesIfNeeded(layer, layerState, commitScope);
updateTilesIfNeeded(layer, layerState, commitScope);
- setLayerFiltersIfNeeded(layer, layerState);
- setLayerAnimationsIfNeeded(layer, layerState);
syncPlatformLayerIfNeeded(layer, layerState);
setLayerRepaintCountIfNeeded(layer, layerState);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
