Diff
Modified: tags/Safari-606.1.15/LayoutTests/ChangeLog (230958 => 230959)
--- tags/Safari-606.1.15/LayoutTests/ChangeLog 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/LayoutTests/ChangeLog 2018-04-24 16:39:18 UTC (rev 230959)
@@ -1,3 +1,7 @@
+2018-04-24 Kocsen Chung <[email protected]>
+
+ Revert r230808. rdar://problem/39671220
+
2018-04-22 Wenson Hsieh <[email protected]>
Add a layout test for r230785
Deleted: tags/Safari-606.1.15/LayoutTests/accessibility/ios-simulator/accessibility-events-setting-expected.txt (230958 => 230959)
--- tags/Safari-606.1.15/LayoutTests/accessibility/ios-simulator/accessibility-events-setting-expected.txt 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/LayoutTests/accessibility/ios-simulator/accessibility-events-setting-expected.txt 2018-04-24 16:39:18 UTC (rev 230959)
@@ -1,13 +0,0 @@
-Click
-This tests that dispatching accessibility events is controled by iOS settings.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS receivedAXEvent is true
-PASS receivedAXEvent is false
-PASS receivedAXEvent is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: tags/Safari-606.1.15/LayoutTests/accessibility/ios-simulator/accessibility-events-setting.html (230958 => 230959)
--- tags/Safari-606.1.15/LayoutTests/accessibility/ios-simulator/accessibility-events-setting.html 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/LayoutTests/accessibility/ios-simulator/accessibility-events-setting.html 2018-04-24 16:39:18 UTC (rev 230959)
@@ -1,52 +0,0 @@
-<!DOCTYPE HTML>
-<html>
-<head>
-<script src=""
-<script src=""
-</head>
-<body>
-
-<button id="button">Click</button>
-
-<p id="description"></p>
-<div id="console"></div>
-
-<script>
- description("This tests that dispatching accessibility events is controled by iOS settings.");
- if (window.accessibilityController) {
- jsTestIsAsync = true;
- var node = document.getElementById("button");
- var axNode = accessibilityController.accessibleElementById("button");
- var receivedAXEvent;
- node._onaccessibleclick_ = function() {
- receivedAXEvent = true;
- };
-
- // By default, accessibility events setting is enabled.
- receivedAXEvent = false;
- axNode.syncPress();
- shouldBeTrue("receivedAXEvent");
-
- // Disable the setting.
- window.internals.settings.setAccessibilityEventsEnabled(false);
- setTimeout(function() {
- receivedAXEvent = false;
- axNode.syncPress();
- shouldBeFalse("receivedAXEvent");
-
- // Re-enable the setting.
- window.internals.settings.setAccessibilityEventsEnabled(true);
- setTimeout(function() {
- receivedAXEvent = false;
- axNode.syncPress();
- shouldBeTrue("receivedAXEvent");
- finishJSTest();
- }, 30);
-
- }, 30);
- }
-
-</script>
-<script src=""
-</body>
-</html>
Modified: tags/Safari-606.1.15/LayoutTests/platform/ios-wk1/TestExpectations (230958 => 230959)
--- tags/Safari-606.1.15/LayoutTests/platform/ios-wk1/TestExpectations 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/LayoutTests/platform/ios-wk1/TestExpectations 2018-04-24 16:39:18 UTC (rev 230959)
@@ -104,7 +104,6 @@
# Not supported on WK1
accessibility/ios-simulator/speak-selection-content.html [ Skip ]
-accessibility/ios-simulator/accessibility-events-setting.html [ Skip ]
# FIXME: Tests that fail due to lack of textInputController <rdar://problem/5106287>
editing/inserting/insert-composition-whitespace.html [ Failure ]
Modified: tags/Safari-606.1.15/LayoutTests/platform/ios-wk2/TestExpectations (230958 => 230959)
--- tags/Safari-606.1.15/LayoutTests/platform/ios-wk2/TestExpectations 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/LayoutTests/platform/ios-wk2/TestExpectations 2018-04-24 16:39:18 UTC (rev 230959)
@@ -1128,8 +1128,6 @@
# Forcing always allow user scalable is not supported on certain OS version.
webkit.org/b/155056 fast/viewport/ios/force-always-user-scalable.html [ Skip ]
-# Setting accessibility events enabled is not supported on certain OS version.
-webkit.org/b/184619 accessibility/ios-simulator/accessibility-events-setting.html [ Skip ]
webkit.org/b/155495 compositing/visible-rect/animated-from-none.html [ Pass Failure ]
webkit.org/b/155495 legacy-animation-engine/compositing/visible-rect/animated-from-none.html [ Pass Failure ]
Modified: tags/Safari-606.1.15/Source/WTF/ChangeLog (230958 => 230959)
--- tags/Safari-606.1.15/Source/WTF/ChangeLog 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WTF/ChangeLog 2018-04-24 16:39:18 UTC (rev 230959)
@@ -1,3 +1,7 @@
+2018-04-24 Kocsen Chung <[email protected]>
+
+ Revert r230808. rdar://problem/39671220
+
2018-04-20 JF Bastien <[email protected]>
Handle more JSON stringify OOM
Modified: tags/Safari-606.1.15/Source/WTF/wtf/Platform.h (230958 => 230959)
--- tags/Safari-606.1.15/Source/WTF/wtf/Platform.h 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WTF/wtf/Platform.h 2018-04-24 16:39:18 UTC (rev 230959)
@@ -1329,8 +1329,4 @@
#define HAVE_AVCONTENTKEYSESSION 1
#endif
-#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 120000) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400)
-#define ENABLE_ACCESSIBILITY_EVENTS 1
-#endif
-
#endif /* WTF_Platform_h */
Modified: tags/Safari-606.1.15/Source/WebCore/ChangeLog (230958 => 230959)
--- tags/Safari-606.1.15/Source/WebCore/ChangeLog 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WebCore/ChangeLog 2018-04-24 16:39:18 UTC (rev 230959)
@@ -1,3 +1,7 @@
+2018-04-24 Kocsen Chung <[email protected]>
+
+ Revert r230808. rdar://problem/39671220
+
2018-04-23 Zalan Bujtas <[email protected]>
[Simple line layout] Generate inline boxtree using simple line layout runs.
Modified: tags/Safari-606.1.15/Source/WebCore/accessibility/AccessibilityObject.cpp (230958 => 230959)
--- tags/Safari-606.1.15/Source/WebCore/accessibility/AccessibilityObject.cpp 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WebCore/accessibility/AccessibilityObject.cpp 2018-04-24 16:39:18 UTC (rev 230959)
@@ -2157,11 +2157,7 @@
bool AccessibilityObject::shouldDispatchAccessibilityEvent() const
{
- bool shouldDispatch = RuntimeEnabledFeatures::sharedFeatures().accessibilityObjectModelEnabled();
-#if ENABLE(ACCESSIBILITY_EVENTS)
- return shouldDispatch &= this->page()->settings().accessibilityEventsEnabled();
-#endif
- return shouldDispatch;
+ return RuntimeEnabledFeatures::sharedFeatures().accessibilityObjectModelEnabled();
}
bool AccessibilityObject::dispatchAccessibilityEvent(Event& event) const
Modified: tags/Safari-606.1.15/Source/WebCore/page/Settings.yaml (230958 => 230959)
--- tags/Safari-606.1.15/Source/WebCore/page/Settings.yaml 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WebCore/page/Settings.yaml 2018-04-24 16:39:18 UTC (rev 230959)
@@ -735,7 +735,3 @@
clientCoordinatesRelativeToLayoutViewport:
initial: false
onChange: setNeedsRecalcStyleInAllFrames
-
-accessibilityEventsEnabled:
- initial: true
- conditional: ACCESSIBILITY_EVENTS
Modified: tags/Safari-606.1.15/Source/WebCore/testing/InternalSettings.cpp (230958 => 230959)
--- tags/Safari-606.1.15/Source/WebCore/testing/InternalSettings.cpp 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WebCore/testing/InternalSettings.cpp 2018-04-24 16:39:18 UTC (rev 230959)
@@ -93,9 +93,6 @@
, m_inlineMediaPlaybackRequiresPlaysInlineAttribute(settings.inlineMediaPlaybackRequiresPlaysInlineAttribute())
, m_deferredCSSParserEnabled(settings.deferredCSSParserEnabled())
, m_inputEventsEnabled(settings.inputEventsEnabled())
-#if ENABLE(ACCESSIBILITY_EVENTS)
- , m_accessibilityEventsEnabled(settings.accessibilityEventsEnabled())
-#endif
, m_userInterfaceDirectionPolicy(settings.userInterfaceDirectionPolicy())
, m_systemLayoutDirection(settings.systemLayoutDirection())
, m_pdfImageCachingPolicy(settings.pdfImageCachingPolicy())
@@ -203,9 +200,6 @@
RenderTheme::singleton().setShouldMockBoldSystemFontForAccessibility(m_shouldMockBoldSystemFontForAccessibility);
FontCache::singleton().setShouldMockBoldSystemFontForAccessibility(m_shouldMockBoldSystemFontForAccessibility);
settings.setFrameFlattening(m_frameFlattening);
-#if ENABLE(ACCESSIBILITY_EVENTS)
- settings.setAccessibilityEventsEnabled(m_accessibilityEventsEnabled);
-#endif
#if ENABLE(INDEXED_DATABASE_IN_WORKERS)
RuntimeEnabledFeatures::sharedFeatures().setIndexedDBWorkersEnabled(m_indexedDBWorkersEnabled);
@@ -882,18 +876,6 @@
return { };
}
-ExceptionOr<void> InternalSettings::setAccessibilityEventsEnabled(bool enabled)
-{
- if (!m_page)
- return Exception { InvalidAccessError };
-#if ENABLE(ACCESSIBILITY_EVENTS)
- settings().setAccessibilityEventsEnabled(enabled);
-#else
- UNUSED_PARAM(enabled);
-#endif
- return { };
-}
-
static InternalSettings::ForcedAccessibilityValue settingsToInternalSettingsValue(Settings::ForcedAccessibilityValue value)
{
switch (value) {
Modified: tags/Safari-606.1.15/Source/WebCore/testing/InternalSettings.h (230958 => 230959)
--- tags/Safari-606.1.15/Source/WebCore/testing/InternalSettings.h 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WebCore/testing/InternalSettings.h 2018-04-24 16:39:18 UTC (rev 230959)
@@ -100,7 +100,6 @@
ExceptionOr<void> setShouldMockBoldSystemFontForAccessibility(bool);
ExceptionOr<void> setShouldManageAudioSessionCategory(bool);
ExceptionOr<void> setCustomPasteboardDataEnabled(bool);
- ExceptionOr<void> setAccessibilityEventsEnabled(bool);
using FrameFlatteningValue = FrameFlattening;
ExceptionOr<void> setFrameFlattening(FrameFlatteningValue);
@@ -190,9 +189,7 @@
bool m_inlineMediaPlaybackRequiresPlaysInlineAttribute;
bool m_deferredCSSParserEnabled;
bool m_inputEventsEnabled;
-#if ENABLE(ACCESSIBILITY_EVENTS)
- bool m_accessibilityEventsEnabled;
-#endif
+
UserInterfaceDirectionPolicy m_userInterfaceDirectionPolicy;
TextDirection m_systemLayoutDirection;
PDFImageCachingPolicy m_pdfImageCachingPolicy;
Modified: tags/Safari-606.1.15/Source/WebCore/testing/InternalSettings.idl (230958 => 230959)
--- tags/Safari-606.1.15/Source/WebCore/testing/InternalSettings.idl 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WebCore/testing/InternalSettings.idl 2018-04-24 16:39:18 UTC (rev 230959)
@@ -111,7 +111,5 @@
[MayThrowException] void setCustomPasteboardDataEnabled(boolean enabled);
[EnabledAtRuntime=WebAnimations] boolean cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled();
-
- [MayThrowException] void setAccessibilityEventsEnabled(boolean enabled);
};
Modified: tags/Safari-606.1.15/Source/WebKit/ChangeLog (230958 => 230959)
--- tags/Safari-606.1.15/Source/WebKit/ChangeLog 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WebKit/ChangeLog 2018-04-24 16:39:18 UTC (rev 230959)
@@ -1,3 +1,7 @@
+2018-04-24 Kocsen Chung <[email protected]>
+
+ Revert r230808. rdar://problem/39671220
+
2018-04-23 Zan Dobersek <[email protected]>
[CoordGraphics] Remove unused trajectory cruft in CoordinatedLayerTreeHost, CoordinatedGraphicsLayer
Modified: tags/Safari-606.1.15/Source/WebKit/Configurations/WebKit.xcconfig (230958 => 230959)
--- tags/Safari-606.1.15/Source/WebKit/Configurations/WebKit.xcconfig 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WebKit/Configurations/WebKit.xcconfig 2018-04-24 16:39:18 UTC (rev 230959)
@@ -39,13 +39,8 @@
LIBRARY_SEARCH_PATHS = $(inherited) "$(LIBWEBRTC_LIBRARY_DIR)";
-WK_ACCESSIBILITY_LDFLAGS = $(WK_ACCESSIBILITY_LDFLAGS_$(WK_PLATFORM_NAME));
-WK_ACCESSIBILITY_LDFLAGS_iphoneos = -lAccessibility;
-WK_ACCESSIBILITY_LDFLAGS_iphonesimulator = $(WK_ACCESSIBILITY_LDFLAGS_iphoneos);
-WK_ACCESSIBILITY_LDFLAGS_watchos = $(WK_ACCESSIBILITY_LDFLAGS_iphoneos);
-WK_ACCESSIBILITY_LDFLAGS_appletvos = $(WK_ACCESSIBILITY_LDFLAGS_iphoneos);
-WK_ACCESSIBILITY_LDFLAGS_macosx = $(WK_ACCESSIBILITY_LDFLAGS$(WK_MACOS_1014));
-WK_ACCESSIBILITY_LDFLAGS_MACOS_SINCE_1014 = -lAccessibility;
+WK_ACCESSIBILITY_LDFLAGS = $(WK_ACCESSIBILITY_LDFLAGS_$(WK_COCOA_TOUCH));
+WK_ACCESSIBILITY_LDFLAGS_cocoatouch = -lAccessibility;
WK_APPKIT_LDFLAGS = $(WK_APPKIT_LDFLAGS_$(WK_PLATFORM_NAME));
WK_APPKIT_LDFLAGS_macosx = -framework AppKit;
Modified: tags/Safari-606.1.15/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (230958 => 230959)
--- tags/Safari-606.1.15/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-04-24 16:39:18 UTC (rev 230959)
@@ -150,6 +150,14 @@
#import <pal/spi/cg/CoreGraphicsSPI.h>
#import <pal/spi/cocoa/QuartzCoreSPI.h>
+#if __has_include(<AccessibilitySupport.h>)
+#include <AccessibilitySupport.h>
+#else
+extern "C" {
+CFStringRef kAXSAllowForceWebScalingEnabledNotification;
+}
+#endif
+
#define RELEASE_LOG_IF_ALLOWED(...) RELEASE_LOG_IF(_page && _page->isAlwaysOnLoggingAllowed(), ViewState, __VA_ARGS__)
@interface UIScrollView (UIScrollViewInternal)
@@ -206,17 +214,6 @@
#endif // HAVE(TOUCH_BAR)
#endif // PLATFORM(MAC)
-#if ENABLE(ACCESSIBILITY_EVENTS)
-#if __has_include(<AccessibilitySupport.h>)
-#include <AccessibilitySupport.h>
-#else
-extern "C" {
-CFStringRef kAXSWebAccessibilityEventsEnabledNotification;
-Boolean _AXSWebAccessibilityEventsEnabled();
-}
-#endif
-#endif
-
static HashMap<WebKit::WebPageProxy*, WKWebView *>& pageToViewMap()
{
static NeverDestroyed<HashMap<WebKit::WebPageProxy*, WKWebView *>> map;
@@ -699,11 +696,6 @@
_impl->setDefaultAppearance([self _defaultAppearance]);
#endif
-#if ENABLE(ACCESSIBILITY_EVENTS)
- CFNotificationCenterAddObserver(CFNotificationCenterGetDarwinNotifyCenter(), (__bridge const void *)(self), accessibilityEventsEnabledChangedCallback, kAXSWebAccessibilityEventsEnabledNotification, 0, CFNotificationSuspensionBehaviorDeliverImmediately);
- [self _updateAccessibilityEventsEnabled];
-#endif
-
_page->setBackgroundExtendsBeyondPage(true);
if (NSString *applicationNameForUserAgent = configuration.applicationNameForUserAgent)
@@ -3063,20 +3055,6 @@
#endif // PLATFORM(IOS)
-#if ENABLE(ACCESSIBILITY_EVENTS)
-static void accessibilityEventsEnabledChangedCallback(CFNotificationCenterRef, void* observer, CFStringRef, const void*, CFDictionaryRef)
-{
- ASSERT(observer);
- WKWebView* webview = static_cast<WKWebView*>(observer);
- [webview _updateAccessibilityEventsEnabled];
-}
-
-- (void)_updateAccessibilityEventsEnabled
-{
- _page->updateAccessibilityEventsEnabled(_AXSWebAccessibilityEventsEnabled());
-}
-#endif
-
#pragma mark OS X-specific methods
#if PLATFORM(MAC)
Modified: tags/Safari-606.1.15/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h (230958 => 230959)
--- tags/Safari-606.1.15/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h 2018-04-24 16:39:18 UTC (rev 230959)
@@ -149,10 +149,6 @@
@property (nonatomic, readonly) UIEdgeInsets _computedUnobscuredSafeAreaInset;
#endif
-#if ENABLE(ACCESSIBILITY_EVENTS)
-- (void)_updateAccessibilityEventsEnabled;
-#endif
-
#if ENABLE(ATTACHMENT_ELEMENT)
- (void)_didRemoveAttachment:(NSString *)identifier;
- (void)_didInsertAttachment:(NSString *)identifier withSource:(NSString *)source;
Modified: tags/Safari-606.1.15/Source/WebKit/UIProcess/WebPageProxy.cpp (230958 => 230959)
--- tags/Safari-606.1.15/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-04-24 16:39:18 UTC (rev 230959)
@@ -2782,16 +2782,6 @@
m_process->send(Messages::WebPage::AccessibilitySettingsDidChange(), m_pageID);
}
-#if ENABLE(ACCESSIBILITY_EVENTS)
-void WebPageProxy::updateAccessibilityEventsEnabled(bool enabled)
-{
- if (!isValid())
- return;
-
- m_process->send(Messages::WebPage::UpdateAccessibilityEventsEnabled(enabled), m_pageID);
-}
-#endif
-
void WebPageProxy::setUseFixedLayout(bool fixed)
{
if (!isValid())
Modified: tags/Safari-606.1.15/Source/WebKit/UIProcess/WebPageProxy.h (230958 => 230959)
--- tags/Safari-606.1.15/Source/WebKit/UIProcess/WebPageProxy.h 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WebKit/UIProcess/WebPageProxy.h 2018-04-24 16:39:18 UTC (rev 230959)
@@ -749,9 +749,6 @@
void setCustomDeviceScaleFactor(float);
void windowScreenDidChange(WebCore::PlatformDisplayID);
void accessibilitySettingsDidChange();
-#if ENABLE(ACCESSIBILITY_EVENTS)
- void updateAccessibilityEventsEnabled(bool);
-#endif
void setUseFixedLayout(bool);
void setFixedLayoutSize(const WebCore::IntSize&);
Modified: tags/Safari-606.1.15/Source/WebKit/WebProcess/WebPage/WebPage.cpp (230958 => 230959)
--- tags/Safari-606.1.15/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2018-04-24 16:39:18 UTC (rev 230959)
@@ -1736,13 +1736,6 @@
m_page->accessibilitySettingsDidChange();
}
-#if ENABLE(ACCESSIBILITY_EVENTS)
-void WebPage::updateAccessibilityEventsEnabled(bool enabled)
-{
- m_page->settings().setAccessibilityEventsEnabled(enabled);
-}
-#endif
-
void WebPage::setUseFixedLayout(bool fixed)
{
// Do not overwrite current settings if initially setting it to false.
Modified: tags/Safari-606.1.15/Source/WebKit/WebProcess/WebPage/WebPage.h (230958 => 230959)
--- tags/Safari-606.1.15/Source/WebKit/WebProcess/WebPage/WebPage.h 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WebKit/WebProcess/WebPage/WebPage.h 2018-04-24 16:39:18 UTC (rev 230959)
@@ -430,9 +430,6 @@
void windowScreenDidChange(uint32_t);
void accessibilitySettingsDidChange();
-#if ENABLE(ACCESSIBILITY_EVENTS)
- void updateAccessibilityEventsEnabled(bool);
-#endif
void scalePage(double scale, const WebCore::IntPoint& origin);
void scalePageInViewCoordinates(double scale, WebCore::IntPoint centerInViewCoordinates);
Modified: tags/Safari-606.1.15/Source/WebKit/WebProcess/WebPage/WebPage.messages.in (230958 => 230959)
--- tags/Safari-606.1.15/Source/WebKit/WebProcess/WebPage/WebPage.messages.in 2018-04-24 16:17:09 UTC (rev 230958)
+++ tags/Safari-606.1.15/Source/WebKit/WebProcess/WebPage/WebPage.messages.in 2018-04-24 16:39:18 UTC (rev 230959)
@@ -209,9 +209,6 @@
WindowScreenDidChange(uint32_t displayID)
AccessibilitySettingsDidChange()
-#if ENABLE(ACCESSIBILITY_EVENTS)
- UpdateAccessibilityEventsEnabled(bool enabled)
-#endif
ScalePage(double scale, WebCore::IntPoint origin)
ScalePageInViewCoordinates(double scale, WebCore::IntPoint centerInViewCoordinates)
