Title: [231016] trunk
- Revision
- 231016
- Author
- [email protected]
- Date
- 2018-04-25 13:34:40 -0700 (Wed, 25 Apr 2018)
Log Message
Don't activate Selection Assistant unless it is actually needed.
https://bugs.webkit.org/show_bug.cgi?id=184944
<rdar://problem/39469671>
Reviewed by Tim Horton.
Source/WebKit:
Don't activate the selection unless we need to. Activating on init is overeager and allowing _javascript_ to
activate selections without user input.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView useSelectionAssistantWithGranularity:]):
LayoutTests:
Turning on previously flakey tests that are fixed with this change.
* platform/ios-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (231015 => 231016)
--- trunk/LayoutTests/ChangeLog 2018-04-25 20:31:25 UTC (rev 231015)
+++ trunk/LayoutTests/ChangeLog 2018-04-25 20:34:40 UTC (rev 231016)
@@ -1,3 +1,15 @@
+2018-04-25 Megan Gardner <[email protected]>
+
+ Don't activate Selection Assistant unless it is actually needed.
+ https://bugs.webkit.org/show_bug.cgi?id=184944
+ <rdar://problem/39469671>
+
+ Reviewed by Tim Horton.
+
+ Turning on previously flakey tests that are fixed with this change.
+
+ * platform/ios-wk2/TestExpectations:
+
2018-04-25 Ross Kirsling <[email protected]>
[WinCairo] Fix js/regexp-unicode.html crash.
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (231015 => 231016)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2018-04-25 20:31:25 UTC (rev 231015)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2018-04-25 20:34:40 UTC (rev 231016)
@@ -1349,21 +1349,4 @@
webkit.org/b/184245 http/tests/workers/service/service-worker-cache-api.https.html [ Pass Failure ]
-#FIXME: <rdar://problem/39469671> Tests that fail when run after fast/events/ios/double-tap-zoom.html with UIWKTextInteractionAssistant turned on
-fast/flexbox/flexbox-fail-to-select-same-line.html [ ImageOnlyFailure Pass ]
-fast/html/marquee-child-wrap.html [ ImageOnlyFailure Pass ]
-fast/misc/subtree-layouts.html [ ImageOnlyFailure Pass ]
-fast/multicol/simple-line-layout-widows-when-switching-over-to-normal-line-layout.html [ ImageOnlyFailure Pass ]
-fast/text/international/hebrew-selection.html [ ImageOnlyFailure Pass ]
-imported/blink/editing/selection/deleteFromDocument-crash.html [ ImageOnlyFailure Pass ]
-imported/blink/editing/style/justify-left-crash.html [ ImageOnlyFailure Pass ]
-imported/blink/fast/css/user-select-none.html [ ImageOnlyFailure Pass ]
-imported/blink/fast/text/international/repaint-glyph-bounds.html [ ImageOnlyFailure Pass ]
-imported/mozilla/svg/text/multiple-chunks-selection.svg [ ImageOnlyFailure Pass ]
-imported/mozilla/svg/text/selectSubString-2.svg [ ImageOnlyFailure Pass ]
-imported/mozilla/svg/text/selectSubString-3.svg [ ImageOnlyFailure Pass ]
-imported/mozilla/svg/text/selectSubString.svg [ ImageOnlyFailure Pass ]
-imported/mozilla/svg/text/textpath-selection.svg [ ImageOnlyFailure Pass ]
-svg/foreignObject/viewport-foreignobject-crash.html [ ImageOnlyFailure Pass ]
-
webkit.org/b/184783 compositing/ios/overflow-scroll-touch-tiles.html [ Pass Failure ]
Modified: trunk/Source/WebKit/ChangeLog (231015 => 231016)
--- trunk/Source/WebKit/ChangeLog 2018-04-25 20:31:25 UTC (rev 231015)
+++ trunk/Source/WebKit/ChangeLog 2018-04-25 20:34:40 UTC (rev 231016)
@@ -1,3 +1,17 @@
+2018-04-25 Megan Gardner <[email protected]>
+
+ Don't activate Selection Assistant unless it is actually needed.
+ https://bugs.webkit.org/show_bug.cgi?id=184944
+ <rdar://problem/39469671>
+
+ Reviewed by Tim Horton.
+
+ Don't activate the selection unless we need to. Activating on init is overeager and allowing _javascript_ to
+ activate selections without user input.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView useSelectionAssistantWithGranularity:]):
+
2018-04-25 Wenson Hsieh <[email protected]>
Fix entitlements and sandbox configurations in WebKit after r230778
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (231015 => 231016)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-04-25 20:31:25 UTC (rev 231015)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-04-25 20:34:40 UTC (rev 231016)
@@ -1932,9 +1932,6 @@
// Reset the gesture recognizers in case editibility has changed.
[_textSelectionAssistant setGestureRecognizers];
}
-
- if (self.isFirstResponder && !self.suppressAssistantSelectionView)
- [_textSelectionAssistant activateSelection];
}
- (void)clearSelection
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
