Title: [231018] trunk/Source/_javascript_Core
Revision
231018
Author
[email protected]
Date
2018-04-25 13:43:42 -0700 (Wed, 25 Apr 2018)

Log Message

getUnlinkedGlobalFunctionExecutable should only save things to the code cache if the option is set
https://bugs.webkit.org/show_bug.cgi?id=184998

Reviewed by Saam Barati.

* runtime/CodeCache.cpp:
(JSC::CodeCache::getUnlinkedGlobalFunctionExecutable):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (231017 => 231018)


--- trunk/Source/_javascript_Core/ChangeLog	2018-04-25 20:35:39 UTC (rev 231017)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-04-25 20:43:42 UTC (rev 231018)
@@ -1,5 +1,15 @@
 2018-04-25  Keith Miller  <[email protected]>
 
+        getUnlinkedGlobalFunctionExecutable should only save things to the code cache if the option is set
+        https://bugs.webkit.org/show_bug.cgi?id=184998
+
+        Reviewed by Saam Barati.
+
+        * runtime/CodeCache.cpp:
+        (JSC::CodeCache::getUnlinkedGlobalFunctionExecutable):
+
+2018-04-25  Keith Miller  <[email protected]>
+
         Add missing scope release to functionProtoFuncToString
         https://bugs.webkit.org/show_bug.cgi?id=184995
 

Modified: trunk/Source/_javascript_Core/runtime/CodeCache.cpp (231017 => 231018)


--- trunk/Source/_javascript_Core/runtime/CodeCache.cpp	2018-04-25 20:35:39 UTC (rev 231017)
+++ trunk/Source/_javascript_Core/runtime/CodeCache.cpp	2018-04-25 20:43:42 UTC (rev 231018)
@@ -158,7 +158,8 @@
     functionExecutable->setSourceURLDirective(source.provider()->sourceURL());
     functionExecutable->setSourceMappingURLDirective(source.provider()->sourceMappingURL());
 
-    m_sourceCode.addCache(key, SourceCodeValue(vm, functionExecutable, m_sourceCode.age()));
+    if (Options::useCodeCache())
+        m_sourceCode.addCache(key, SourceCodeValue(vm, functionExecutable, m_sourceCode.age()));
     return functionExecutable;
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to