Title: [231116] trunk/Source/_javascript_Core
- Revision
- 231116
- Author
- [email protected]
- Date
- 2018-04-27 16:43:30 -0700 (Fri, 27 Apr 2018)
Log Message
Also run foldPathConstants before mussing up SSA
https://bugs.webkit.org/show_bug.cgi?id=185069
Reviewed by Saam Barati.
This isn't needed now, but will be once I implement the phase in bug 185060.
This could be a speed-up, or a slow-down, independent of that phase. Most likely it's neutral.
Local testing seems to suggest that it's neutral. Anyway, whatever it ends up being, I want it to
be landed separately and measured separately from that phase.
It's probably nice for sanity to have this and reduceStrength run before tail duplication and
another round of reduceStrength, since that make for something that is closer to a fixpoint. But
it will increase FTL compile times. So, there's no way to guess if this change is good, bad, or
neutral. It all depends on what programs typically look like.
* b3/B3Generate.cpp:
(JSC::B3::generateToAir):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (231115 => 231116)
--- trunk/Source/_javascript_Core/ChangeLog 2018-04-27 22:30:43 UTC (rev 231115)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-04-27 23:43:30 UTC (rev 231116)
@@ -1,3 +1,24 @@
+2018-04-26 Filip Pizlo <[email protected]>
+
+ Also run foldPathConstants before mussing up SSA
+ https://bugs.webkit.org/show_bug.cgi?id=185069
+
+ Reviewed by Saam Barati.
+
+ This isn't needed now, but will be once I implement the phase in bug 185060.
+
+ This could be a speed-up, or a slow-down, independent of that phase. Most likely it's neutral.
+ Local testing seems to suggest that it's neutral. Anyway, whatever it ends up being, I want it to
+ be landed separately and measured separately from that phase.
+
+ It's probably nice for sanity to have this and reduceStrength run before tail duplication and
+ another round of reduceStrength, since that make for something that is closer to a fixpoint. But
+ it will increase FTL compile times. So, there's no way to guess if this change is good, bad, or
+ neutral. It all depends on what programs typically look like.
+
+ * b3/B3Generate.cpp:
+ (JSC::B3::generateToAir):
+
2018-04-27 Ryan Haddad <[email protected]>
Unreviewed, rolling out r231086.
Modified: trunk/Source/_javascript_Core/b3/B3Generate.cpp (231115 => 231116)
--- trunk/Source/_javascript_Core/b3/B3Generate.cpp 2018-04-27 22:30:43 UTC (rev 231115)
+++ trunk/Source/_javascript_Core/b3/B3Generate.cpp 2018-04-27 23:43:30 UTC (rev 231116)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2015-2017 Apple Inc. All rights reserved.
+ * Copyright (C) 2015-2018 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -87,6 +87,8 @@
hoistLoopInvariantValues(procedure);
if (eliminateCommonSubexpressions(procedure))
eliminateCommonSubexpressions(procedure);
+ foldPathConstants(procedure);
+ reduceStrength(procedure);
inferSwitches(procedure);
duplicateTails(procedure);
fixSSA(procedure);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
