Title: [231122] trunk/Tools
- Revision
- 231122
- Author
- commit-qu...@webkit.org
- Date
- 2018-04-27 17:21:55 -0700 (Fri, 27 Apr 2018)
Log Message
[WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
https://bugs.webkit.org/show_bug.cgi?id=185049
Patch by Stephan Szabo <stephan.sz...@sony.com> on 2018-04-27
Reviewed by Keith Miller.
* Scripts/run-_javascript_core-tests:
(runJSCStressTests):
* Scripts/run-jsc-stress-tests:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (231121 => 231122)
--- trunk/Tools/ChangeLog 2018-04-28 00:07:38 UTC (rev 231121)
+++ trunk/Tools/ChangeLog 2018-04-28 00:21:55 UTC (rev 231122)
@@ -1,3 +1,14 @@
+2018-04-27 Stephan Szabo <stephan.sz...@sony.com>
+
+ [WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
+ https://bugs.webkit.org/show_bug.cgi?id=185049
+
+ Reviewed by Keith Miller.
+
+ * Scripts/run-_javascript_core-tests:
+ (runJSCStressTests):
+ * Scripts/run-jsc-stress-tests:
+
2018-04-26 Ryosuke Niwa <rn...@webkit.org>
PSON: Triggering a navigation to an invalid URL creates a new WebContent process
Modified: trunk/Tools/Scripts/run-_javascript_core-tests (231121 => 231122)
--- trunk/Tools/Scripts/run-_javascript_core-tests 2018-04-28 00:07:38 UTC (rev 231121)
+++ trunk/Tools/Scripts/run-_javascript_core-tests 2018-04-28 00:21:55 UTC (rev 231122)
@@ -58,6 +58,7 @@
my $memoryLimited;
my $buildJSC = 1;
+my $copyJSC = 1;
use constant {
ENV_VAR_SAYS_DO_RUN => 4,
@@ -148,6 +149,17 @@
}
}
+if ($ENV{RUN_JAVASCRIPTCORE_TESTS_COPY}) {
+ if ($ENV{RUN_JAVASCRIPTCORE_TESTS_COPY} eq "true") {
+ $copyJSC = 1;
+ } elsif ($ENV{RUN_JAVASCRIPTCORE_TESTS_COPY} eq "false") {
+ $copyJSC = 0;
+ } else {
+ print "Don't recognize value for RUN_JAVASCRIPTCORE_TESTS_COPY environment variable: '"
+ . $ENV{RUN_JAVASCRIPTCORE_TESTS_COPY} . "'. Should be set to 'true' or 'false'.\n";
+ }
+}
+
if ($ENV{RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS}) {
push @extraTests, $ENV{RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS};
}
@@ -174,6 +186,7 @@
my $jitStressTestsDefault = $runJITStressTests ? "will run" : " will not run";
my $quickModeDefault = $runQuickMode ? "some" : "all";
my $failFastDefault = $failFast ? "fail fast" : "don't fail fast";
+my $copyJSCDefault = $copyJSC ? "copy" : "do not copy";
my $filter;
my $usage = <<EOF;
Usage: $programName [options] [options to pass to build system]
@@ -194,6 +207,7 @@
--[no-]fail-fast Stop this script when a test family reports an error or failure (default: $failFastDefault)
--[no-]force-collectContinuously Enable the collectContinuously mode even if it was disabled on this platform.
+ --[no-]copy Copy (or don't copy) the _javascript_Core build product before testing (default: $copyJSCDefault)
--json-output= Create a file at specified path, listing failed stress tests in JSON format.
--tarball Create a tarball of the bundle produced by running the JSC stress tests.
--remote= Run the JSC stress tests on the specified remote host. Implies --tarball.
@@ -248,6 +262,7 @@
'quick!' => \$runQuickMode,
'fail-fast!' => \$failFast,
'force-collectContinuously!' => \$forceCollectContinuously,
+ 'copy!' => \$copyJSC,
'json-output=s' => \$jsonFileName,
'tarball!' => \$createTarball,
'remote=s' => \$remoteHost,
@@ -437,6 +452,10 @@
push(@jscStressDriverCmd, "--debug");
}
+ if (!$copyJSC) {
+ push(@jscStressDriverCmd, "--no-copy");
+ }
+
if ($forceCollectContinuously) {
push(@jscStressDriverCmd, "--force-collectContinuously");
}
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (231121 => 231122)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2018-04-28 00:07:38 UTC (rev 231121)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2018-04-28 00:21:55 UTC (rev 231122)
@@ -1579,7 +1579,7 @@
if $doNotMessWithVMPath
if !$remote and !$tarball
- $testingFrameworkPath = frameworkFromJSCPath($jscPath).realpath
+ $testingFrameworkPath = (frameworkFromJSCPath($jscPath) || $jscPath.dirname).realpath
$jscPath = Pathname.new($jscPath).realpath
else
$testingFrameworkPath = frameworkFromJSCPath($jscPath)
@@ -1599,7 +1599,19 @@
destination = Pathname.new(".vm")
elsif $hostOS == "windows"
# Make sure to copy dll along with jsc on Windows
- source = [originalJSCPath] + Dir.glob(File.dirname(originalJSCPath) + "/jscLib.dll")
+ originalJSCDir = File.dirname(originalJSCPath)
+ source = [originalJSCPath] + [originalJSCDir + "/jscLib.dll"]
+
+ # Check for and copy _javascript_Core.dll and WTF.dll for dynamic builds
+ _javascript_CoreDLLPath = File.join(originalJSCDir, "_javascript_Core.dll")
+ wtfDLLPath = File.join(originalJSCDir, "WTF.dll")
+ if (File.exists?(_javascript_CoreDLLPath))
+ source = source + [_javascript_CoreDLLPath]
+ end
+ if (File.exists?(wtfDLLPath))
+ source = source + [wtfDLLPath]
+ end
+
destination = $jscPath.dirname
Dir.chdir($outputDir) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
