Title: [231179] trunk
- Revision
- 231179
- Author
- jer.no...@apple.com
- Date
- 2018-04-30 16:42:22 -0700 (Mon, 30 Apr 2018)
Log Message
<img src="" does not display on ios despite Accept: video/* advertisement
https://bugs.webkit.org/show_bug.cgi?id=185029
<rdar://problem/39771989>
Reviewed by Eric Carlson.
Source/WebCore:
Returning "NO" from resourceLoader:shouldWaitForLoadingOfResource: signals that the load failed,
even if the resource request is successfully fulfilled prior to the return. Always return YES in
the case that loading succeeded.
* platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
(-[WebCoreSharedBufferResourceLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
LayoutTests:
* platform/ios/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (231178 => 231179)
--- trunk/LayoutTests/ChangeLog 2018-04-30 23:16:42 UTC (rev 231178)
+++ trunk/LayoutTests/ChangeLog 2018-04-30 23:42:22 UTC (rev 231179)
@@ -1,3 +1,13 @@
+2018-04-30 Jer Noble <jer.no...@apple.com>
+
+ <img src="" does not display on ios despite Accept: video/* advertisement
+ https://bugs.webkit.org/show_bug.cgi?id=185029
+ <rdar://problem/39771989>
+
+ Reviewed by Eric Carlson.
+
+ * platform/ios/TestExpectations:
+
2018-04-30 Zalan Bujtas <za...@apple.com>
REGRESSION(r230914) Selecting text on this apple.com page makes it vanish
Modified: trunk/LayoutTests/platform/ios/TestExpectations (231178 => 231179)
--- trunk/LayoutTests/platform/ios/TestExpectations 2018-04-30 23:16:42 UTC (rev 231178)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2018-04-30 23:42:22 UTC (rev 231179)
@@ -1111,10 +1111,6 @@
fast/viewport/ios/viewport-fit-auto.html [ Pass ]
fast/css/variables/env/ios [ Pass ]
-# This test relies on APIs not available on iOS
-fast/images/animated-image-mp4.html [ Skip ]
-
-
###
# Known failures
##
Modified: trunk/Source/WebCore/ChangeLog (231178 => 231179)
--- trunk/Source/WebCore/ChangeLog 2018-04-30 23:16:42 UTC (rev 231178)
+++ trunk/Source/WebCore/ChangeLog 2018-04-30 23:42:22 UTC (rev 231179)
@@ -1,3 +1,18 @@
+2018-04-30 Jer Noble <jer.no...@apple.com>
+
+ <img src="" does not display on ios despite Accept: video/* advertisement
+ https://bugs.webkit.org/show_bug.cgi?id=185029
+ <rdar://problem/39771989>
+
+ Reviewed by Eric Carlson.
+
+ Returning "NO" from resourceLoader:shouldWaitForLoadingOfResource: signals that the load failed,
+ even if the resource request is successfully fulfilled prior to the return. Always return YES in
+ the case that loading succeeded.
+
+ * platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
+ (-[WebCoreSharedBufferResourceLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
+
2018-04-30 Zalan Bujtas <za...@apple.com>
REGRESSION(r230914) Selecting text on this apple.com page makes it vanish
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm (231178 => 231179)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm 2018-04-30 23:16:42 UTC (rev 231178)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm 2018-04-30 23:42:22 UTC (rev 231179)
@@ -203,7 +203,7 @@
if ([self canFulfillRequest:loadingRequest]) {
[self fulfillRequest:loadingRequest];
if (loadingRequest.finished)
- return NO;
+ return YES;
}
[self enqueueRequest:loadingRequest];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
