Title: [231255] trunk/LayoutTests
- Revision
- 231255
- Author
- [email protected]
- Date
- 2018-05-02 12:53:38 -0700 (Wed, 02 May 2018)
Log Message
Layout Test http/wpt/service-workers/header-filtering.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=184469
<rdar://problem/39428226>
Reviewed by Chris Dumez.
Ensure that the message posted for the loading of the initial iframe is actually received before doing further tests.
* http/wpt/service-workers/header-filtering.https.html:
* platform/mac-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (231254 => 231255)
--- trunk/LayoutTests/ChangeLog 2018-05-02 19:29:30 UTC (rev 231254)
+++ trunk/LayoutTests/ChangeLog 2018-05-02 19:53:38 UTC (rev 231255)
@@ -1,3 +1,16 @@
+2018-05-02 Youenn Fablet <[email protected]>
+
+ Layout Test http/wpt/service-workers/header-filtering.https.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=184469
+ <rdar://problem/39428226>
+
+ Reviewed by Chris Dumez.
+
+ Ensure that the message posted for the loading of the initial iframe is actually received before doing further tests.
+
+ * http/wpt/service-workers/header-filtering.https.html:
+ * platform/mac-wk2/TestExpectations:
+
2018-05-02 Chris Dumez <[email protected]>
document.open() event listener removal is not immediate
Modified: trunk/LayoutTests/http/wpt/service-workers/header-filtering.https.html (231254 => 231255)
--- trunk/LayoutTests/http/wpt/service-workers/header-filtering.https.html 2018-05-02 19:29:30 UTC (rev 231254)
+++ trunk/LayoutTests/http/wpt/service-workers/header-filtering.https.html 2018-05-02 19:53:38 UTC (rev 231255)
@@ -40,24 +40,31 @@
});
}
+var processMessage;
promise_test(async (test) => {
registration = await registerServiceWorker(scope);
registration.active.postMessage("ready?");
+
+ navigator.serviceWorker._onmessage_ = (event) => {
+ processMessage(event.data);
+ };
+
return new Promise((resolve) => {
- navigator.serviceWorker._onmessage_ = (event) => {
+ processMessage = (data) => {
assert_equals(event.data, "ready");
- navigator.serviceWorker._onmessage_ = undefined;
resolve();
- };
+ }
});
}, "Prepare tests: setup worker and register the client");
-var processMessage;
promise_test(async (test) => {
+ const promise = new Promise((resolve) => {
+ processMessage = (data) => {
+ resolve(data);
+ };
+ });
frame = await withFrame(scope + "/header-filtering-iframe.html");
- navigator.serviceWorker._onmessage_ = (event) => {
- processMessage(event.data);
- };
+ await promise;
}, "Prepare tests: Add a frame controlled by service worker");
promise_test(async (test) => {
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (231254 => 231255)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2018-05-02 19:29:30 UTC (rev 231254)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2018-05-02 19:53:38 UTC (rev 231255)
@@ -885,4 +885,3 @@
webkit.org/b/177380 http/tests/cache-storage/cache-records-persistency.https.html [ Pass Failure ]
-webkit.org/b/184469 http/wpt/service-workers/header-filtering.https.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes