Diff
Modified: trunk/Source/WebKit/ChangeLog (231364 => 231365)
--- trunk/Source/WebKit/ChangeLog 2018-05-04 18:01:21 UTC (rev 231364)
+++ trunk/Source/WebKit/ChangeLog 2018-05-04 18:35:59 UTC (rev 231365)
@@ -1,3 +1,24 @@
+2018-05-04 Youenn Fablet <[email protected]>
+
+ NetworkProcessProxy::didReceiveAuthenticationChallenge should take an AuthenticationChallenge r-value
+ https://bugs.webkit.org/show_bug.cgi?id=185302
+
+ Reviewed by Geoffrey Garen.
+
+ Pass AuthenticationChallenge as an r-value since it comes from IPC.
+ No change of behavior.
+
+ * UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
+ (WebKit::AuthenticationChallengeProxy::AuthenticationChallengeProxy):
+ * UIProcess/Authentication/AuthenticationChallengeProxy.h:
+ (WebKit::AuthenticationChallengeProxy::create):
+ * UIProcess/Downloads/DownloadProxy.cpp:
+ (WebKit::DownloadProxy::didReceiveAuthenticationChallenge):
+ * UIProcess/Downloads/DownloadProxy.h:
+ * UIProcess/Network/NetworkProcessProxy.cpp:
+ (WebKit::NetworkProcessProxy::didReceiveAuthenticationChallenge):
+ * UIProcess/Network/NetworkProcessProxy.h:
+
2018-05-04 Sihui Liu <[email protected]>
Assertion failure in NetworkStorageSession::setCookie: privilege of UI process is not set
Modified: trunk/Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.cpp (231364 => 231365)
--- trunk/Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.cpp 2018-05-04 18:01:21 UTC (rev 231364)
+++ trunk/Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.cpp 2018-05-04 18:35:59 UTC (rev 231365)
@@ -37,8 +37,8 @@
namespace WebKit {
-AuthenticationChallengeProxy::AuthenticationChallengeProxy(const WebCore::AuthenticationChallenge& authenticationChallenge, uint64_t challengeID, IPC::Connection* connection)
- : m_coreAuthenticationChallenge(authenticationChallenge)
+AuthenticationChallengeProxy::AuthenticationChallengeProxy(WebCore::AuthenticationChallenge&& authenticationChallenge, uint64_t challengeID, IPC::Connection* connection)
+ : m_coreAuthenticationChallenge(WTFMove(authenticationChallenge))
, m_challengeID(challengeID)
, m_connection(connection)
{
Modified: trunk/Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h (231364 => 231365)
--- trunk/Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h 2018-05-04 18:01:21 UTC (rev 231364)
+++ trunk/Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h 2018-05-04 18:35:59 UTC (rev 231365)
@@ -41,9 +41,9 @@
class AuthenticationChallengeProxy : public API::ObjectImpl<API::Object::Type::AuthenticationChallenge> {
public:
- static Ref<AuthenticationChallengeProxy> create(const WebCore::AuthenticationChallenge& authenticationChallenge, uint64_t challengeID, IPC::Connection* connection)
+ static Ref<AuthenticationChallengeProxy> create(WebCore::AuthenticationChallenge&& authenticationChallenge, uint64_t challengeID, IPC::Connection* connection)
{
- return adoptRef(*new AuthenticationChallengeProxy(authenticationChallenge, challengeID, connection));
+ return adoptRef(*new AuthenticationChallengeProxy(WTFMove(authenticationChallenge), challengeID, connection));
}
~AuthenticationChallengeProxy();
@@ -60,7 +60,7 @@
const WebCore::AuthenticationChallenge& core() { return m_coreAuthenticationChallenge; }
private:
- AuthenticationChallengeProxy(const WebCore::AuthenticationChallenge&, uint64_t challengeID, IPC::Connection*);
+ AuthenticationChallengeProxy(WebCore::AuthenticationChallenge&&, uint64_t challengeID, IPC::Connection*);
WebCore::AuthenticationChallenge m_coreAuthenticationChallenge;
uint64_t m_challengeID;
Modified: trunk/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp (231364 => 231365)
--- trunk/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp 2018-05-04 18:01:21 UTC (rev 231364)
+++ trunk/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp 2018-05-04 18:35:59 UTC (rev 231365)
@@ -116,12 +116,12 @@
m_processPool->downloadClient().didStart(*m_processPool, *this);
}
-void DownloadProxy::didReceiveAuthenticationChallenge(const AuthenticationChallenge& authenticationChallenge, uint64_t challengeID)
+void DownloadProxy::didReceiveAuthenticationChallenge(AuthenticationChallenge&& authenticationChallenge, uint64_t challengeID)
{
if (!m_processPool)
return;
- auto authenticationChallengeProxy = AuthenticationChallengeProxy::create(authenticationChallenge, challengeID, m_processPool->networkingProcessConnection());
+ auto authenticationChallengeProxy = AuthenticationChallengeProxy::create(WTFMove(authenticationChallenge), challengeID, m_processPool->networkingProcessConnection());
m_processPool->downloadClient().didReceiveAuthenticationChallenge(*m_processPool, *this, authenticationChallengeProxy.get());
}
Modified: trunk/Source/WebKit/UIProcess/Downloads/DownloadProxy.h (231364 => 231365)
--- trunk/Source/WebKit/UIProcess/Downloads/DownloadProxy.h 2018-05-04 18:01:21 UTC (rev 231364)
+++ trunk/Source/WebKit/UIProcess/Downloads/DownloadProxy.h 2018-05-04 18:35:59 UTC (rev 231365)
@@ -88,7 +88,7 @@
// Message handlers.
void didStart(const WebCore::ResourceRequest&, const String& suggestedFilename);
- void didReceiveAuthenticationChallenge(const WebCore::AuthenticationChallenge&, uint64_t challengeID);
+ void didReceiveAuthenticationChallenge(WebCore::AuthenticationChallenge&&, uint64_t challengeID);
void didReceiveResponse(const WebCore::ResourceResponse&);
void didReceiveData(uint64_t length);
void shouldDecodeSourceDataOfMIMEType(const String& mimeType, bool& result);
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (231364 => 231365)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2018-05-04 18:01:21 UTC (rev 231364)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2018-05-04 18:35:59 UTC (rev 231365)
@@ -293,11 +293,11 @@
#endif
}
-void NetworkProcessProxy::didReceiveAuthenticationChallenge(uint64_t pageID, uint64_t frameID, const WebCore::AuthenticationChallenge& coreChallenge, uint64_t challengeID)
+void NetworkProcessProxy::didReceiveAuthenticationChallenge(uint64_t pageID, uint64_t frameID, WebCore::AuthenticationChallenge&& coreChallenge, uint64_t challengeID)
{
#if ENABLE(SERVICE_WORKER)
if (auto* serviceWorkerProcessProxy = m_processPool.serviceWorkerProcessProxyFromPageID(pageID)) {
- auto authenticationChallenge = AuthenticationChallengeProxy::create(coreChallenge, challengeID, connection());
+ auto authenticationChallenge = AuthenticationChallengeProxy::create(WTFMove(coreChallenge), challengeID, connection());
serviceWorkerProcessProxy->didReceiveAuthenticationChallenge(pageID, frameID, WTFMove(authenticationChallenge));
return;
}
@@ -306,7 +306,7 @@
WebPageProxy* page = WebProcessProxy::webPage(pageID);
MESSAGE_CHECK(page);
- auto authenticationChallenge = AuthenticationChallengeProxy::create(coreChallenge, challengeID, connection());
+ auto authenticationChallenge = AuthenticationChallengeProxy::create(WTFMove(coreChallenge), challengeID, connection());
page->didReceiveAuthenticationChallengeProxy(frameID, WTFMove(authenticationChallenge));
}
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h (231364 => 231365)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h 2018-05-04 18:01:21 UTC (rev 231364)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h 2018-05-04 18:35:59 UTC (rev 231365)
@@ -128,7 +128,7 @@
// Message handlers
void didReceiveNetworkProcessProxyMessage(IPC::Connection&, IPC::Decoder&);
void didCreateNetworkConnectionToWebProcess(const IPC::Attachment&);
- void didReceiveAuthenticationChallenge(uint64_t pageID, uint64_t frameID, const WebCore::AuthenticationChallenge&, uint64_t challengeID);
+ void didReceiveAuthenticationChallenge(uint64_t pageID, uint64_t frameID, WebCore::AuthenticationChallenge&&, uint64_t challengeID);
void didFetchWebsiteData(uint64_t callbackID, const WebsiteData&);
void didDeleteWebsiteData(uint64_t callbackID);
void didDeleteWebsiteDataForOrigins(uint64_t callbackID);
