Title: [231369] trunk
- Revision
- 231369
- Author
- [email protected]
- Date
- 2018-05-04 11:52:47 -0700 (Fri, 04 May 2018)
Log Message
REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
https://bugs.webkit.org/show_bug.cgi?id=184196
<rdar://problem/39054481>
Patch by Wenson Hsieh <[email protected]> on 2018-05-04
Reviewed by Tim Horton.
Source/WebKit:
Remove an unnecessary call to NSClassFromString, now that trunk WebKit only supports iOS 11.3+.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView insertTextSuggestion:]):
Tools:
Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
earlier than 11.3. Also re-enables these tests.
* TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
(TestWebKitAPI::TEST):
(-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
(+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (231368 => 231369)
--- trunk/Source/WebKit/ChangeLog 2018-05-04 18:50:30 UTC (rev 231368)
+++ trunk/Source/WebKit/ChangeLog 2018-05-04 18:52:47 UTC (rev 231369)
@@ -1,3 +1,16 @@
+2018-05-04 Wenson Hsieh <[email protected]>
+
+ REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
+ https://bugs.webkit.org/show_bug.cgi?id=184196
+ <rdar://problem/39054481>
+
+ Reviewed by Tim Horton.
+
+ Remove an unnecessary call to NSClassFromString, now that trunk WebKit only supports iOS 11.3+.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView insertTextSuggestion:]):
+
2018-05-04 Youenn Fablet <[email protected]>
NetworkProcessProxy::didReceiveAuthenticationChallenge should take an AuthenticationChallenge r-value
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (231368 => 231369)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-05-04 18:50:30 UTC (rev 231368)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-05-04 18:52:47 UTC (rev 231369)
@@ -3149,7 +3149,7 @@
- (void)insertTextSuggestion:(UITextSuggestion *)textSuggestion
{
// FIXME: Replace NSClassFromString with actual class as soon as UIKit submitted the new class into the iOS SDK.
- if ([textSuggestion isKindOfClass:NSClassFromString(@"UITextAutofillSuggestion")]) {
+ if ([textSuggestion isKindOfClass:[UITextAutofillSuggestion class]]) {
_page->autofillLoginCredentials([(UITextAutofillSuggestion *)textSuggestion username], [(UITextAutofillSuggestion *)textSuggestion password]);
return;
}
Modified: trunk/Tools/ChangeLog (231368 => 231369)
--- trunk/Tools/ChangeLog 2018-05-04 18:50:30 UTC (rev 231368)
+++ trunk/Tools/ChangeLog 2018-05-04 18:52:47 UTC (rev 231369)
@@ -1,3 +1,19 @@
+2018-05-04 Wenson Hsieh <[email protected]>
+
+ REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
+ https://bugs.webkit.org/show_bug.cgi?id=184196
+ <rdar://problem/39054481>
+
+ Reviewed by Tim Horton.
+
+ Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
+ earlier than 11.3. Also re-enables these tests.
+
+ * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
+ (TestWebKitAPI::TEST):
+ (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
+ (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
+
2018-05-04 Myles C. Maxfield <[email protected]>
Text shaping in the simple path is flipped in the y direction
Modified: trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm (231368 => 231369)
--- trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm 2018-05-04 18:50:30 UTC (rev 231368)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm 2018-05-04 18:52:47 UTC (rev 231369)
@@ -35,26 +35,6 @@
#import <WebKit/_WKInputDelegate.h>
#import <wtf/BlockPtr.h>
-#if !__has_include(<UIKit/UITextAutofillSuggestion.h>)
-// FIXME: This can be safely removed once <rdar://problem/34583628> lands in the SDK.
-@implementation UITextAutofillSuggestion
-- (instancetype)initWithUsername:(NSString *)username password:(NSString *)password
-{
- self = [super init];
- if (self) {
- _username = username;
- _password = password;
- }
- return self;
-}
-
-+ (instancetype)autofillSuggestionWithUsername:(NSString *)username password:(NSString *)password
-{
- return [[self alloc] initWithUsername:username password:password];
-}
-@end
-#endif
-
typedef UIView <UITextInputTraits_Private_Proposed_SPI_34583628> AutofillInputView;
@interface TestInputDelegate : NSObject <_WKInputDelegate>
@@ -115,7 +95,7 @@
namespace TestWebKitAPI {
-TEST(WKWebViewAutofillTests, DISABLED_UsernameAndPasswordField)
+TEST(WKWebViewAutofillTests, UsernameAndPasswordField)
{
auto webView = adoptNS([[AutofillTestView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
[webView synchronouslyLoadHTMLString:@"<input id='user' type='email'><input id='password' type='password'>"];
@@ -134,7 +114,7 @@
EXPECT_FALSE([webView textInputHasAutofillContext]);
}
-TEST(WKWebViewAutofillTests, DISABLED_UsernameAndPasswordFieldSeparatedByRadioButton)
+TEST(WKWebViewAutofillTests, UsernameAndPasswordFieldSeparatedByRadioButton)
{
auto webView = adoptNS([[AutofillTestView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
[webView synchronouslyLoadHTMLString:@"<input id='user' type='email'><input type='radio' name='radio_button' value='radio'><input id='password' type='password'>"];
@@ -165,7 +145,7 @@
EXPECT_FALSE([webView textInputHasAutofillContext]);
}
-TEST(WKWebViewAutofillTests, DISABLED_StandalonePasswordField)
+TEST(WKWebViewAutofillTests, StandalonePasswordField)
{
auto webView = adoptNS([[AutofillTestView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
[webView synchronouslyLoadHTMLString:@"<input id='password' type='password'>"];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
