Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js (101067 => 101068)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js 2011-11-23 12:48:12 UTC (rev 101067)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js 2011-11-23 13:03:25 UTC (rev 101068)
@@ -40,12 +40,15 @@
var CRASH = 'CRASH';
var IMAGE = 'IMAGE';
var IMAGE_TEXT = 'IMAGE+TEXT';
+var AUDIO = 'AUDIO';
-var kFailingResults = [TIMEOUT, TEXT, CRASH, IMAGE, IMAGE_TEXT];
+var kFailingResults = [TIMEOUT, TEXT, CRASH, IMAGE, IMAGE_TEXT, AUDIO];
var kExpectedImageSuffix = '-expected.png';
var kActualImageSuffix = '-actual.png';
var kImageDiffSuffix = '-diff.png';
+var kExpectedAudioSuffix = '-expected.wav';
+var kActualAudioSuffix = '-actual.wav';
var kExpectedTextSuffix = '-expected.txt';
var kActualTextSuffix = '-actual.txt';
var kDiffTextSuffix = '-diff.txt';
@@ -53,6 +56,7 @@
var kPNGExtension = 'png';
var kTXTExtension = 'txt';
+var kWAVExtension = 'wav';
var kPreferredSuffixOrder = [
kExpectedImageSuffix,
@@ -62,6 +66,8 @@
kActualTextSuffix,
kDiffTextSuffix,
kCrashLogSuffix,
+ kExpectedAudioSuffix,
+ kActualAudioSuffix,
// FIXME: Add support for the rest of the result types.
];
@@ -73,6 +79,7 @@
// Types of tests.
results.kImageType = 'image'
+results.kTextType = 'audio'
results.kTextType = 'text'
// FIXME: There are more types of tests.
@@ -87,6 +94,12 @@
suffixList.push(kImageDiffSuffix);
}
+ function pushAudioSuffixes()
+ {
+ suffixList.push(kExpectedAudioSuffix);
+ suffixList.push(kActualAudioSuffix);
+ }
+
function pushTextSuffixes()
{
suffixList.push(kActualTextSuffix);
@@ -104,6 +117,9 @@
case TEXT:
pushTextSuffixes();
break;
+ case AUDIO:
+ pushAudioSuffixes();
+ break;
case IMAGE_TEXT:
pushImageSuffixes();
pushTextSuffixes();
@@ -115,8 +131,6 @@
// FIXME: Add support for the rest of the result types.
// '-expected.html',
// '-expected-mismatch.html',
- // '-expected.wav',
- // '-actual.wav',
// ... and possibly more.
break;
}
@@ -130,6 +144,8 @@
switch(failureType) {
case IMAGE:
return [kPNGExtension];
+ case AUDIO:
+ return [kWAVExtension];
case TEXT:
return [kTXTExtension];
case IMAGE_TEXT:
@@ -138,8 +154,6 @@
// FIXME: Add support for the rest of the result types.
// '-expected.html',
// '-expected-mismatch.html',
- // '-expected.wav',
- // '-actual.wav',
// ... and possibly more.
return [];
}
@@ -491,6 +505,8 @@
{
if (/\.png$/.test(url))
return results.kImageType;
+ if (/\.wav$/.test(url))
+ return results.kAudioType;
return results.kTextType;
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css (101067 => 101068)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css 2011-11-23 12:48:12 UTC (rev 101067)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css 2011-11-23 13:03:25 UTC (rev 101068)
@@ -210,6 +210,10 @@
background-color: #ffc343;
}
+ ol.notifications table.failures tbody tr.AUDIO td:first-child span {
+ background-color: #bfdfff;
+ }
+
ol.notifications table.failures tbody tr.IMAGE td:first-child span {
background-color: #69f;
}
Modified: trunk/Tools/ChangeLog (101067 => 101068)
--- trunk/Tools/ChangeLog 2011-11-23 12:48:12 UTC (rev 101067)
+++ trunk/Tools/ChangeLog 2011-11-23 13:03:25 UTC (rev 101068)
@@ -1,3 +1,18 @@
+2011-11-23 Adam Barth <[email protected]>
+
+ garden-o-matic should support AUDIO failures
+ https://bugs.webkit.org/show_bug.cgi?id=69477
+
+ Reviewed by Dimitri Glazkov.
+
+ This is a first iteration at supporting AUDIO failures in
+ garden-o-matic. We'll probably need to iterate a bit when we have a
+ real audio failure in the tree to play with. For example, we'll
+ probably want to add and <audio> element to the "Examine" view to hear
+ the differences, but that all can be done in a subsequent patch.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
+
2011-11-23 Scott Graham <[email protected]>
Adding gamepad support
