Title: [101072] trunk/Tools
- Revision
- 101072
- Author
- [email protected]
- Date
- 2011-11-23 05:38:49 -0800 (Wed, 23 Nov 2011)
Log Message
garden-o-matic should explain more clearly what the builder lists at the top of the page mean
https://bugs.webkit.org/show_bug.cgi?id=72992
Reviewed by Dimitri Glazkov.
This patch also prepares us to list other sorts of failures, like
performance and unit test.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js (101071 => 101072)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js 2011-11-23 13:20:01 UTC (rev 101071)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js 2011-11-23 13:38:49 UTC (rev 101072)
@@ -232,9 +232,10 @@
});
controllers.FailingBuilders = base.extends(Object, {
- init: function(view)
+ init: function(view, message)
{
this._view = view;
+ this._message = message;
this._notification = null;
},
update: function(builderNameList)
@@ -247,7 +248,7 @@
return;
}
if (!this._notification) {
- this._notification = new ui.notifications.BuildersFailing();
+ this._notification = new ui.notifications.BuildersFailing(this._message);
this._view.add(this._notification);
}
// FIXME: We should provide regression ranges for the failing builders.
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js (101071 => 101072)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js 2011-11-23 13:20:01 UTC (rev 101071)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js 2011-11-23 13:38:49 UTC (rev 101072)
@@ -32,7 +32,7 @@
var g_unexpectedFailuresController = null;
-var g_failingBuilders = null;
+var g_losingTestCoverageBuilders = null;
function update()
{
@@ -42,7 +42,7 @@
g_info.add(updating);
- builders.buildersFailingStepRequredForTestCoverage(g_failingBuilders.update.bind(g_failingBuilders));
+ builders.buildersFailingStepRequredForTestCoverage(g_losingTestCoverageBuilders.update.bind(g_losingTestCoverageBuilders));
base.callInParallel([model.updateRecentCommits, model.updateResultsByBuilder], function() {
updating.update('Analyzing test failures ...');
@@ -83,7 +83,7 @@
g_unexpectedFailuresController = new controllers.UnexpectedFailures(model.state, unexpectedFailuresView, onebarController);
g_info = new ui.notifications.Stream();
- g_failingBuilders = new controllers.FailingBuilders(g_info);
+ g_losingTestCoverageBuilders = new controllers.FailingBuilders(g_info, 'Losing test coverage');
// FIXME: This should be an Action object.
var updateButton = document.body.insertBefore(document.createElement('button'), document.body.firstChild);
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js (101071 => 101072)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2011-11-23 13:20:01 UTC (rev 101071)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2011-11-23 13:38:49 UTC (rev 101072)
@@ -247,9 +247,9 @@
});
ui.notifications.BuildersFailing = base.extends(ui.notifications.Failure, {
- init: function()
+ init: function(message)
{
- this._problem.insertBefore(document.createTextNode('Build Failed:'), this._problem.firstChild);
+ this._problem.insertBefore(document.createTextNode(message + ':'), this._problem.firstChild);
},
setFailingBuilders: function(builderNameList)
{
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (101071 => 101072)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-11-23 13:20:01 UTC (rev 101071)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-11-23 13:38:49 UTC (rev 101072)
@@ -317,14 +317,14 @@
});
test('BuildersFailing', 1, function() {
- var builderFailing = new ui.notifications.BuildersFailing();
+ var builderFailing = new ui.notifications.BuildersFailing('Disasterifying');
builderFailing.setFailingBuilders(['Webkit Linux', 'Webkit Vista']);
equal(builderFailing.innerHTML,
'<div class="how">' +
'<time class="relative"></time>' +
'</div>' +
'<div class="what">' +
- '<div class="problem">Build Failed:' +
+ '<div class="problem">Disasterifying:' +
'<ul class="effects">' +
'<li class="builder"><a class="failing-builder" target="_blank" href="" class="version">lucid</span><span class="architecture">64-bit</span></a></li>' +
'<li class="builder"><a class="failing-builder" target="_blank" href="" class="version">vista</span></a></li>' +
Modified: trunk/Tools/ChangeLog (101071 => 101072)
--- trunk/Tools/ChangeLog 2011-11-23 13:20:01 UTC (rev 101071)
+++ trunk/Tools/ChangeLog 2011-11-23 13:38:49 UTC (rev 101072)
@@ -1,3 +1,18 @@
+2011-11-23 Adam Barth <[email protected]>
+
+ garden-o-matic should explain more clearly what the builder lists at the top of the page mean
+ https://bugs.webkit.org/show_bug.cgi?id=72992
+
+ Reviewed by Dimitri Glazkov.
+
+ This patch also prepares us to list other sorts of failures, like
+ performance and unit test.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
+
2011-11-23 Ryan Sleevi <[email protected]>
Add new Chromium tests to the flakiness dashboard
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
