Title: [231453] trunk/LayoutTests
- Revision
- 231453
- Author
- [email protected]
- Date
- 2018-05-07 13:48:36 -0700 (Mon, 07 May 2018)
Log Message
Layout Test webrtc/addICECandidate-closed.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=185384
Reviewed by Eric Carlson.
Given that we are calling addIceCandidate and close the peer connection,
addIceCandidate might throw an error sometimes.
Catch the exception to make the test output stable.
* webrtc/addICECandidate-closed.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (231452 => 231453)
--- trunk/LayoutTests/ChangeLog 2018-05-07 20:08:16 UTC (rev 231452)
+++ trunk/LayoutTests/ChangeLog 2018-05-07 20:48:36 UTC (rev 231453)
@@ -1,3 +1,16 @@
+2018-05-07 Youenn Fablet <[email protected]>
+
+ Layout Test webrtc/addICECandidate-closed.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=185384
+
+ Reviewed by Eric Carlson.
+
+ Given that we are calling addIceCandidate and close the peer connection,
+ addIceCandidate might throw an error sometimes.
+ Catch the exception to make the test output stable.
+
+ * webrtc/addICECandidate-closed.html:
+
2018-05-07 Chris Dumez <[email protected]>
ASSERT(!childItemWithTarget(child->target())) is hit in HistoryItem::addChildItem()
Modified: trunk/LayoutTests/webrtc/addICECandidate-closed.html (231452 => 231453)
--- trunk/LayoutTests/webrtc/addICECandidate-closed.html 2018-05-07 20:08:16 UTC (rev 231452)
+++ trunk/LayoutTests/webrtc/addICECandidate-closed.html 2018-05-07 20:48:36 UTC (rev 231453)
@@ -15,8 +15,10 @@
const localTracks = stream.getTracks();
[[sender, receiver], [receiver, sender]].forEach(([pc1, pc2]) => {
pc1._onicecandidate_ = ({ candidate }) => {
- if (candidate)
- pc2.addIceCandidate(candidate);
+ try {
+ if (candidate)
+ pc2.addIceCandidate(candidate);
+ } catch (e) { }
pc1.close();
};
});
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
