Title: [231465] trunk/Source/WebKit
- Revision
- 231465
- Author
- [email protected]
- Date
- 2018-05-07 16:57:22 -0700 (Mon, 07 May 2018)
Log Message
WebResourceLoadStatisticsStore::requestStorageAccess should call its completion handler on the main thread
https://bugs.webkit.org/show_bug.cgi?id=185403
Reviewed by Brent Fulgham.
* UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (231464 => 231465)
--- trunk/Source/WebKit/ChangeLog 2018-05-07 23:37:46 UTC (rev 231464)
+++ trunk/Source/WebKit/ChangeLog 2018-05-07 23:57:22 UTC (rev 231465)
@@ -1,3 +1,13 @@
+2018-05-07 Alex Christensen <[email protected]>
+
+ WebResourceLoadStatisticsStore::requestStorageAccess should call its completion handler on the main thread
+ https://bugs.webkit.org/show_bug.cgi?id=185403
+
+ Reviewed by Brent Fulgham.
+
+ * UIProcess/WebResourceLoadStatisticsStore.cpp:
+ (WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):
+
2018-05-07 Chris Dumez <[email protected]>
[iOS] Release page load process assertion if the screen is locked
Modified: trunk/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp (231464 => 231465)
--- trunk/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp 2018-05-07 23:37:46 UTC (rev 231464)
+++ trunk/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp 2018-05-07 23:57:22 UTC (rev 231465)
@@ -371,18 +371,26 @@
auto& subFrameStatistic = ensureResourceStatisticsForPrimaryDomain(subFramePrimaryDomain);
if (shouldBlockCookies(subFrameStatistic)) {
- callback(false);
+ callOnMainThread([callback = WTFMove(callback)] {
+ callback(false);
+ });
return;
}
if (!shouldPartitionCookies(subFrameStatistic)) {
- callback(true);
+ callOnMainThread([callback = WTFMove(callback)] {
+ callback(true);
+ });
return;
}
subFrameStatistic.timesAccessedAsFirstPartyDueToStorageAccessAPI++;
- m_grantStorageAccessHandler(subFramePrimaryDomain, topFramePrimaryDomain, frameID, pageID, WTFMove(callback));
+ m_grantStorageAccessHandler(subFramePrimaryDomain, topFramePrimaryDomain, frameID, pageID, [callback = WTFMove(callback)] (bool value) mutable {
+ callOnMainThread([value, callback = WTFMove(callback)] {
+ callback(value);
+ });
+ });
});
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
