Title: [101074] trunk/Tools
- Revision
- 101074
- Author
- [email protected]
- Date
- 2011-11-23 05:58:02 -0800 (Wed, 23 Nov 2011)
Log Message
garden-o-matic should display a message if it can't find results to display
https://bugs.webkit.org/show_bug.cgi?id=72991
Reviewed by Dimitri Glazkov.
Not all failures (e.g., TIMEOUT) have results that we can display.
This patch adds a short message so that the user can see that we're
done trying to load the results.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js (101073 => 101074)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2011-11-23 13:45:31 UTC (rev 101073)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2011-11-23 13:58:02 UTC (rev 101074)
@@ -135,6 +135,9 @@
}
this.addComparison(resultType, resultsURLsByKind);
}.bind(this));
+
+ if (!this.children.length)
+ this.textContent = 'No results to display.'
}
});
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js (101073 => 101074)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js 2011-11-23 13:45:31 UTC (rev 101073)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js 2011-11-23 13:58:02 UTC (rev 101074)
@@ -46,9 +46,18 @@
}
}
+var kExampleResultsWithTimeoutByTest = {
+ "fast/not-fast-test.html": {
+ "Mock Builder": {
+ "expected": "PASS",
+ "actual": "TIMEOUT"
+ }
+ }
+}
+
test('View', 8, function() {
var delegate = {
- fetchResultsURLs: function(failureInfo, callback) { return;}
+ fetchResultsURLs: function(failureInfo, callback) { return; }
};
var view = new ui.results.View(delegate);
@@ -68,4 +77,16 @@
equals($($('.builder-selector', view)[0]).tabs('option', 'selected'), 1);
});
+test('View of timeouts', 1, function() {
+ var delegate = {
+ fetchResultsURLs: function(failureInfo, callback) { callback([]); }
+ };
+
+ var view = new ui.results.View(delegate);
+ view.setResultsByTest(kExampleResultsWithTimeoutByTest);
+ view.firstResult();
+
+ equals($('.results-grid', view).html(), 'No results to display.');
+});
+
})();
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js (101073 => 101074)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js 2011-11-23 13:45:31 UTC (rev 101073)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js 2011-11-23 13:58:02 UTC (rev 101074)
@@ -98,7 +98,7 @@
test("results.ResultsGrid (empty)", 1, function() {
var grid = new ui.results.ResultsGrid()
grid.addResults([]);
- equal(grid.innerHTML, '');
+ equal(grid.innerHTML, 'No results to display.');
});
test("time", 6, function() {
Modified: trunk/Tools/ChangeLog (101073 => 101074)
--- trunk/Tools/ChangeLog 2011-11-23 13:45:31 UTC (rev 101073)
+++ trunk/Tools/ChangeLog 2011-11-23 13:58:02 UTC (rev 101074)
@@ -1,5 +1,20 @@
2011-11-23 Adam Barth <[email protected]>
+ garden-o-matic should display a message if it can't find results to display
+ https://bugs.webkit.org/show_bug.cgi?id=72991
+
+ Reviewed by Dimitri Glazkov.
+
+ Not all failures (e.g., TIMEOUT) have results that we can display.
+ This patch adds a short message so that the user can see that we're
+ done trying to load the results.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
+
+2011-11-23 Adam Barth <[email protected]>
+
garden-o-matic should explain more clearly what the builder lists at the top of the page mean
https://bugs.webkit.org/show_bug.cgi?id=72992
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
