Diff
Modified: trunk/LayoutTests/ChangeLog (231498 => 231499)
--- trunk/LayoutTests/ChangeLog 2018-05-08 18:58:25 UTC (rev 231498)
+++ trunk/LayoutTests/ChangeLog 2018-05-08 19:23:54 UTC (rev 231499)
@@ -1,5 +1,24 @@
2018-05-08 Youenn Fablet <[email protected]>
+ Some appcache crash tests are flaky due to console messages
+ https://bugs.webkit.org/show_bug.cgi?id=185431
+
+ Reviewed by Geoffrey Garen.
+
+ Mark 3 tests that were written to test crashes as DumpJSConsoleLogInStdErr.
+ It is better to mark them as such than to changing them since they might no longer cover the crash reasons.
+ Rebase two other tests that might need further work to stop being flaky.
+
+ * TestExpectations:
+ * http/tests/appcache/404-resource-with-slow-main-resource-expected.txt:
+ * http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt:
+ * http/tests/appcache/deferred-events-expected.txt:
+ * http/tests/appcache/fail-on-update-2-expected.txt:
+ * http/tests/appcache/fail-on-update-expected.txt:
+ * platform/mac/TestExpectations:
+
+2018-05-08 Youenn Fablet <[email protected]>
+
Skip http/tests/appcache/load-from-appcache-defer-resume-crash.html for iOS sim WK2
https://bugs.webkit.org/show_bug.cgi?id=185430
Modified: trunk/LayoutTests/TestExpectations (231498 => 231499)
--- trunk/LayoutTests/TestExpectations 2018-05-08 18:58:25 UTC (rev 231498)
+++ trunk/LayoutTests/TestExpectations 2018-05-08 19:23:54 UTC (rev 231499)
@@ -1016,8 +1016,9 @@
webkit.org/b/87633 http/tests/appcache/deferred-events-delete-while-raising.html [ Pass Failure ]
webkit.org/b/87633 http/tests/appcache/deferred-events.html [ Pass Failure ]
-webkit.org/b/147520 http/tests/appcache/fail-on-update.html [ Pass Failure ]
-webkit.org/b/147520 http/tests/appcache/fail-on-update-2.html [ Pass Failure ]
+http/tests/appcache/fail-on-update.html [ DumpJSConsoleLogInStdErr ]
+http/tests/appcache/fail-on-update-2.html [ DumpJSConsoleLogInStdErr ]
+http/tests/appcache/404-resource-with-slow-main-resource.php [ DumpJSConsoleLogInStdErr ]
webkit.org/b/141370 http/tests/security/appcache-in-private-browsing.html [ Pass Failure ]
Modified: trunk/LayoutTests/http/tests/appcache/404-resource-with-slow-main-resource-expected.txt (231498 => 231499)
--- trunk/LayoutTests/http/tests/appcache/404-resource-with-slow-main-resource-expected.txt 2018-05-08 18:58:25 UTC (rev 231498)
+++ trunk/LayoutTests/http/tests/appcache/404-resource-with-slow-main-resource-expected.txt 2018-05-08 19:23:54 UTC (rev 231499)
@@ -1,4 +1,2 @@
-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
-CONSOLE MESSAGE: Application Cache update failed, because http://127.0.0.1:8000/appcache/resources/does-not-exist.txt could not be fetched.
This tests that a manifest that contains a missing file will not crash the browser even if the main resource keeps loading after the error occurs.
SUCCESS
Modified: trunk/LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt (231498 => 231499)
--- trunk/LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt 2018-05-08 18:58:25 UTC (rev 231498)
+++ trunk/LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt 2018-05-08 19:23:54 UTC (rev 231499)
@@ -1,4 +1,4 @@
CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
-CONSOLE MESSAGE: line 13: Application Cache download process was aborted.
+CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
This tests that download process was aborted after checking event and before update failed.
SUCCESS
Modified: trunk/LayoutTests/http/tests/appcache/deferred-events-expected.txt (231498 => 231499)
--- trunk/LayoutTests/http/tests/appcache/deferred-events-expected.txt 2018-05-08 18:58:25 UTC (rev 231498)
+++ trunk/LayoutTests/http/tests/appcache/deferred-events-expected.txt 2018-05-08 19:23:54 UTC (rev 231499)
@@ -1,3 +1,4 @@
CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
+CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
Test that AppicationCache events are deferred until after onload has been fired.
SUCCESS
Modified: trunk/LayoutTests/http/tests/appcache/fail-on-update-2-expected.txt (231498 => 231499)
--- trunk/LayoutTests/http/tests/appcache/fail-on-update-2-expected.txt 2018-05-08 18:58:25 UTC (rev 231498)
+++ trunk/LayoutTests/http/tests/appcache/fail-on-update-2-expected.txt 2018-05-08 19:23:54 UTC (rev 231499)
@@ -1,7 +1 @@
-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
-CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
-CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
SUCCESS: No crash.
Modified: trunk/LayoutTests/http/tests/appcache/fail-on-update-expected.txt (231498 => 231499)
--- trunk/LayoutTests/http/tests/appcache/fail-on-update-expected.txt 2018-05-08 18:58:25 UTC (rev 231498)
+++ trunk/LayoutTests/http/tests/appcache/fail-on-update-expected.txt 2018-05-08 19:23:54 UTC (rev 231499)
@@ -1,4 +1 @@
-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
-CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
-CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
SUCCESS: No crash.
Modified: trunk/LayoutTests/platform/mac/TestExpectations (231498 => 231499)
--- trunk/LayoutTests/platform/mac/TestExpectations 2018-05-08 18:58:25 UTC (rev 231498)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2018-05-08 19:23:54 UTC (rev 231499)
@@ -1731,8 +1731,6 @@
webkit.org/b/181612 [ Debug ] webanimations/animation-opacity-animation-crash.html [ Pass Failure ]
-webkit.org/b/172241 http/tests/appcache/404-resource-with-slow-main-resource.php [ Pass Failure ]
-
webkit.org/b/173946 [ Debug ] media/modern-media-controls/fullscreen-support/fullscreen-support-press.html [ Pass Failure ]
webkit.org/b/183490 media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html [ Failure ]
