Title: [101080] trunk/Source/WebCore
- Revision
- 101080
- Author
- [email protected]
- Date
- 2011-11-23 06:34:09 -0800 (Wed, 23 Nov 2011)
Log Message
Web Inspector: warning icon for unrecognized style rule should have tooltip
https://bugs.webkit.org/show_bug.cgi?id=50638
Reviewed by Yury Semikhatsky.
* English.lproj/localizedStrings.js: Add new tooltip strings.
* inspector/front-end/CSSCompletions.js:
(WebInspector.CSSCompletions.prototype.keySet): Added.
* inspector/front-end/StylesSidebarPane.js: Create a separate IMG element for an exclamation mark.
* inspector/front-end/elementsPanel.css:
(.styles-section .properties li.not-parsed-ok img.exclamation-mark):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (101079 => 101080)
--- trunk/Source/WebCore/ChangeLog 2011-11-23 14:25:45 UTC (rev 101079)
+++ trunk/Source/WebCore/ChangeLog 2011-11-23 14:34:09 UTC (rev 101080)
@@ -1,3 +1,17 @@
+2011-11-23 Alexander Pavlov <[email protected]>
+
+ Web Inspector: warning icon for unrecognized style rule should have tooltip
+ https://bugs.webkit.org/show_bug.cgi?id=50638
+
+ Reviewed by Yury Semikhatsky.
+
+ * English.lproj/localizedStrings.js: Add new tooltip strings.
+ * inspector/front-end/CSSCompletions.js:
+ (WebInspector.CSSCompletions.prototype.keySet): Added.
+ * inspector/front-end/StylesSidebarPane.js: Create a separate IMG element for an exclamation mark.
+ * inspector/front-end/elementsPanel.css:
+ (.styles-section .properties li.not-parsed-ok img.exclamation-mark):
+
2011-11-23 Halton Huo <[email protected]>
[EFL] Add zlib depend when freetype is used.
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js
(Binary files differ)
Modified: trunk/Source/WebCore/inspector/front-end/CSSCompletions.js (101079 => 101080)
--- trunk/Source/WebCore/inspector/front-end/CSSCompletions.js 2011-11-23 14:25:45 UTC (rev 101079)
+++ trunk/Source/WebCore/inspector/front-end/CSSCompletions.js 2011-11-23 14:34:09 UTC (rev 101080)
@@ -109,7 +109,9 @@
keySet: function()
{
- return this._values.keySet();
+ if (!this._keySet)
+ this._keySet = this._values.keySet();
+ return this._keySet;
},
next: function(str, prefix)
Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js (101079 => 101080)
--- trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2011-11-23 14:25:45 UTC (rev 101079)
+++ trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2011-11-23 14:34:09 UTC (rev 101080)
@@ -1745,6 +1745,12 @@
// Avoid having longhands under an invalid shorthand.
this.hasChildren = false;
this.listItemElement.addStyleClass("not-parsed-ok");
+
+ // Add a separate exclamation mark IMG element with a tooltip.
+ var exclamationElement = document.createElement("img");
+ exclamationElement.className = "exclamation-mark";
+ exclamationElement.title = WebInspector.CSSCompletions.cssNameCompletions.keySet()[this.property.name] ? WebInspector.UIString("Invalid property value.") : WebInspector.UIString("Unknown property name.");
+ this.listItemElement.insertBefore(exclamationElement, this.listItemElement.firstChild);
}
if (this.property.inactive)
this.listItemElement.addStyleClass("inactive");
Modified: trunk/Source/WebCore/inspector/front-end/elementsPanel.css (101079 => 101080)
--- trunk/Source/WebCore/inspector/front-end/elementsPanel.css 2011-11-23 14:25:45 UTC (rev 101079)
+++ trunk/Source/WebCore/inspector/front-end/elementsPanel.css 2011-11-23 14:34:09 UTC (rev 101080)
@@ -230,15 +230,14 @@
margin-left: 0px;
}
-.styles-section .properties li.not-parsed-ok::before {
+.styles-section .properties li.not-parsed-ok img.exclamation-mark {
content: url(Images/warningIcon.png);
opacity: 0.75;
- float: left;
- width: 8px;
- height: 8px;
- margin-top: 0;
- padding-right: 5px;
- vertical-align: sub;
+ width: 12px;
+ height: 10px;
+ margin: 0;
+ padding-right: 2px;
+ vertical-align: baseline;
-webkit-user-select: none;
cursor: default;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
