Title: [231600] trunk
- Revision
- 231600
- Author
- [email protected]
- Date
- 2018-05-09 15:04:54 -0700 (Wed, 09 May 2018)
Log Message
[GStreamer] Never call updateTracks if running on legacy pipeline
https://bugs.webkit.org/show_bug.cgi?id=184581
Source/WebCore:
This makes sure failling code path is never reached in the conditions where it should not have been reached.
Patch by Thibault Saunier <[email protected]> on 2018-05-09
Reviewed by Philippe Normand.
Re enables all tests that were disabled after fixing.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
LayoutTests:
Patch by Thibault Saunier <[email protected]> on 2018-05-09
Reviewed by Philippe Normand.
https://bugs.webkit.org/show_bug.cgi?id=185252
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (231599 => 231600)
--- trunk/LayoutTests/ChangeLog 2018-05-09 21:59:44 UTC (rev 231599)
+++ trunk/LayoutTests/ChangeLog 2018-05-09 22:04:54 UTC (rev 231600)
@@ -1,3 +1,14 @@
+2018-05-09 Thibault Saunier <[email protected]>
+
+ [GStreamer] Never call updateTracks if running on legacy pipeline
+ https://bugs.webkit.org/show_bug.cgi?id=184581
+
+ Reviewed by Philippe Normand.
+
+ https://bugs.webkit.org/show_bug.cgi?id=185252
+
+ * platform/gtk/TestExpectations:
+
2018-05-09 Ross Kirsling <[email protected]>
Unreviewed gardening for WinCairo LayoutTests.
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (231599 => 231600)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2018-05-09 21:59:44 UTC (rev 231599)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2018-05-09 22:04:54 UTC (rev 231600)
@@ -1005,6 +1005,8 @@
# Tests failing with GStreamer 1.6.3
webkit.org/b/154390 http/tests/media/video-throttled-load-metadata.html [ Pass Failure ]
webkit.org/b/154390 http/tests/media/video-redirect.html [ Timeout Pass ]
+webkit.org/b/154390 [ Release ] http/tests/media/hls/video-controller-getStartDate.html [ Timeout Failure ]
+webkit.org/b/154390 [ Release ] http/tests/media/hls/hls-audio-tracks-locale-selection.html [ Timeout Failure ]
webkit.org/b/154390 [ Release ] http/tests/media/hls/hls-video-resize.html [ Timeout Failure ]
webkit.org/b/154390 http/tests/security/local-video-source-from-remote.html [ Timeout Pass ]
@@ -1246,11 +1248,6 @@
webkit.org/b/152043 [ Debug ] http/tests/media/hls [ Timeout Crash ]
-# Tests crashing since addition of playbin3 usage
-webkit.org/b/184581 http/tests/media/hls/hls-audio-tracks-locale-selection.html [ Timeout Failure Crash ]
-webkit.org/b/184581 http/tests/media/hls/hls-progress.html [ Crash ]
-webkit.org/b/184581 http/tests/media/hls/video-controller-getStartDate.html [ Timeout Failure Crash ]
-
webkit.org/b/152642 http/tests/misc/detached-frame-console.html [ Crash Pass Timeout Failure ]
webkit.org/b/153692 imported/blink/fast/css/first-letter-float-block.html [ Crash Pass ]
@@ -3358,8 +3355,6 @@
webkit.org/b/184779 transitions/clip-path-path-transitions.html [ Failure ]
webkit.org/b/184779 transitions/clip-path-transitions.html [ Failure ]
-webkit.org/b/185252 http/tests/media/hls/hls-audio-tracks.html [ Failure ]
-
webkit.org/b/185254 http/tests/cache/disk-cache/redirect-chain-limits.html [ Failure ]
webkit.org/b/185254 http/tests/xmlhttprequest/onloadend-event-after-error.html [ Failure ]
webkit.org/b/185254 http/tests/xmlhttprequest/response-access-on-error.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (231599 => 231600)
--- trunk/Source/WebCore/ChangeLog 2018-05-09 21:59:44 UTC (rev 231599)
+++ trunk/Source/WebCore/ChangeLog 2018-05-09 22:04:54 UTC (rev 231600)
@@ -1,3 +1,17 @@
+2018-05-09 Thibault Saunier <[email protected]>
+
+ [GStreamer] Never call updateTracks if running on legacy pipeline
+ https://bugs.webkit.org/show_bug.cgi?id=184581
+
+ This makes sure failling code path is never reached in the conditions where it should not have been reached.
+
+ Reviewed by Philippe Normand.
+
+ Re enables all tests that were disabled after fixing.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::handleMessage):
+
2018-05-09 Daniel Bates <[email protected]>
REGRESSION (r231479): http/tests/appcache/x-frame-options-prevents-framing.php is timing out
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (231599 => 231600)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2018-05-09 21:59:44 UTC (rev 231599)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2018-05-09 22:04:54 UTC (rev 231600)
@@ -1295,6 +1295,9 @@
}
#if GST_CHECK_VERSION(1, 10, 0)
case GST_MESSAGE_STREAM_COLLECTION: {
+ if (m_isLegacyPlaybin)
+ break;
+
GRefPtr<GstStreamCollection> collection;
gst_message_parse_stream_collection(message, &collection.outPtr());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
