Title: [231635] trunk/Source/WebKitLegacy/win
- Revision
- 231635
- Author
- [email protected]
- Date
- 2018-05-10 00:15:42 -0700 (Thu, 10 May 2018)
Log Message
REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
https://bugs.webkit.org/show_bug.cgi?id=185505
Unreviewed serious crash fix
Windows port crashes soon since Bug 184996.
* WebPreferences.cpp:
(WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
* WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
Modified Paths
Diff
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (231634 => 231635)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2018-05-10 07:11:43 UTC (rev 231634)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2018-05-10 07:15:42 UTC (rev 231635)
@@ -1,3 +1,16 @@
+2018-05-10 Fujii Hironori <[email protected]>
+
+ REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
+ https://bugs.webkit.org/show_bug.cgi?id=185505
+
+ Unreviewed serious crash fix
+
+ Windows port crashes soon since Bug 184996.
+
+ * WebPreferences.cpp:
+ (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
+ * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
+
2018-05-07 Daniel Bates <[email protected]>
Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
Modified: trunk/Source/WebKitLegacy/win/WebPreferences.cpp (231634 => 231635)
--- trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2018-05-10 07:11:43 UTC (rev 231634)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2018-05-10 07:15:42 UTC (rev 231635)
@@ -576,6 +576,8 @@
*ppvObject = static_cast<IWebPreferencesPrivate5*>(this);
else if (IsEqualGUID(riid, IID_IWebPreferencesPrivate6))
*ppvObject = static_cast<IWebPreferencesPrivate6*>(this);
+ else if (IsEqualGUID(riid, IID_IWebPreferencesPrivate7))
+ *ppvObject = static_cast<IWebPreferencesPrivate7*>(this);
else if (IsEqualGUID(riid, CLSID_WebPreferences))
*ppvObject = this;
else
Modified: trunk/Source/WebKitLegacy/win/WebPreferences.h (231634 => 231635)
--- trunk/Source/WebKitLegacy/win/WebPreferences.h 2018-05-10 07:11:43 UTC (rev 231634)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.h 2018-05-10 07:15:42 UTC (rev 231635)
@@ -30,7 +30,7 @@
#include <WebCore/BString.h>
#include <wtf/RetainPtr.h>
-class WebPreferences : public IWebPreferences, public IWebPreferencesPrivate6 {
+class WebPreferences : public IWebPreferences, public IWebPreferencesPrivate7 {
public:
static WebPreferences* createInstance();
protected:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
