Title: [231664] trunk/Source/WebKit
- Revision
- 231664
- Author
- [email protected]
- Date
- 2018-05-10 15:06:23 -0700 (Thu, 10 May 2018)
Log Message
Remove Unused Chinese/Japanese Reanalyze code
https://bugs.webkit.org/show_bug.cgi?id=185529
Reviewed by Wenson Hsieh.
The code for this has actually been completely removed from UIKit. This is unreachable
dead code that should be removed if just for cleanliness.
* Platform/spi/ios/UIKitSPI.h:
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView _reanalyzeForWebView:]): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (231663 => 231664)
--- trunk/Source/WebKit/ChangeLog 2018-05-10 22:02:31 UTC (rev 231663)
+++ trunk/Source/WebKit/ChangeLog 2018-05-10 22:06:23 UTC (rev 231664)
@@ -1,3 +1,20 @@
+2018-05-10 Megan Gardner <[email protected]>
+
+ Remove Unused Chinese/Japanese Reanalyze code
+ https://bugs.webkit.org/show_bug.cgi?id=185529
+
+ Reviewed by Wenson Hsieh.
+
+ The code for this has actually been completely removed from UIKit. This is unreachable
+ dead code that should be removed if just for cleanliness.
+
+ * Platform/spi/ios/UIKitSPI.h:
+ * UIProcess/API/Cocoa/WKWebViewInternal.h:
+ * UIProcess/ios/WKContentViewInteraction.h:
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView canPerformActionForWebView:withSender:]):
+ (-[WKContentView _reanalyzeForWebView:]): Deleted.
+
2018-05-10 Chris Dumez <[email protected]>
[iOS] Apps that are not visible may not get suspended if they trigger page loads while in the background
Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (231663 => 231664)
--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2018-05-10 22:02:31 UTC (rev 231663)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2018-05-10 22:06:23 UTC (rev 231664)
@@ -1015,7 +1015,6 @@
BOOL UIKeyboardEnabledInputModesAllowOneToManyShortcuts(void);
BOOL UIKeyboardEnabledInputModesAllowChineseTransliterationForText(NSString *);
-BOOL UIKeyboardCurrentInputModeAllowsChineseOrJapaneseReanalysisForText(NSString *);
extern const float UITableCellDefaultFontSize;
extern const float UITableViewCellDefaultFontSize;
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h (231663 => 231664)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h 2018-05-10 22:02:31 UTC (rev 231663)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h 2018-05-10 22:06:23 UTC (rev 231664)
@@ -129,7 +129,6 @@
- (void)_arrowKey:(id)sender;
- (void)_define:(id)sender;
- (void)_lookup:(id)sender;
-- (void)_reanalyze:(id)sender;
- (void)_share:(id)sender;
- (void)_showTextStyleOptions:(id)sender;
- (void)_promptForReplace:(id)sender;
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h (231663 => 231664)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2018-05-10 22:02:31 UTC (rev 231663)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2018-05-10 22:06:23 UTC (rev 231664)
@@ -108,7 +108,6 @@
M(_define) \
M(_lookup) \
M(_promptForReplace) \
- M(_reanalyze) \
M(_share) \
M(_showTextStyleOptions) \
M(_transliterateChinese) \
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (231663 => 231664)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-05-10 22:02:31 UTC (rev 231663)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-05-10 22:06:23 UTC (rev 231664)
@@ -265,7 +265,6 @@
// FIXME: this needs to be moved from the internal header to the private.
- (id)initWithView:(UIResponder <UITextInput> *)view;
- (void)selectWord;
-- (void)scheduleReanalysis;
@end
@interface UIView (UIViewInternalHack)
@@ -2154,11 +2153,6 @@
[_textSelectionAssistant scheduleChineseTransliterationForText:_page->editorState().postLayoutData().wordAtSelection];
}
-- (void)_reanalyzeForWebView:(id)sender
-{
- [_textSelectionAssistant scheduleReanalysis];
-}
-
- (void)replaceForWebView:(id)sender
{
[[UIKeyboardImpl sharedInstance] replaceText:sender];
@@ -2311,12 +2305,6 @@
return UIKeyboardEnabledInputModesAllowChineseTransliterationForText([self selectedText]);
}
- if (action == @selector(_reanalyze:)) {
- if (!_page->editorState().selectionIsRange || !_page->editorState().postLayoutData().isReplaceAllowed || ![[UIKeyboardImpl activeInstance] autocorrectSpellingEnabled])
- return NO;
- return UIKeyboardCurrentInputModeAllowsChineseOrJapaneseReanalysisForText([self selectedText]);
- }
-
if (action == @selector(select:)) {
// Disable select in password fields so that you can't see word boundaries.
return !_page->editorState().isInPasswordField && [self hasContent] && !_page->editorState().selectionIsNone && !_page->editorState().selectionIsRange;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
