Title: [231677] trunk/Tools
- Revision
- 231677
- Author
- rn...@webkit.org
- Date
- 2018-05-10 17:06:32 -0700 (Thu, 10 May 2018)
Log Message
build-webkit can erroneously warn about Xcode being too old
https://bugs.webkit.org/show_bug.cgi?id=185533
Reviewed by Dan Bernstein.
Don't assume the version number is always a single digit.
* Scripts/webkitdirs.pm:
(determineXcodeVersion):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (231676 => 231677)
--- trunk/Tools/ChangeLog 2018-05-10 23:35:32 UTC (rev 231676)
+++ trunk/Tools/ChangeLog 2018-05-11 00:06:32 UTC (rev 231677)
@@ -1,3 +1,15 @@
+2018-05-10 Ryosuke Niwa <rn...@webkit.org>
+
+ build-webkit can erroneously warn about Xcode being too old
+ https://bugs.webkit.org/show_bug.cgi?id=185533
+
+ Reviewed by Dan Bernstein.
+
+ Don't assume the version number is always a single digit.
+
+ * Scripts/webkitdirs.pm:
+ (determineXcodeVersion):
+
2018-05-10 Ross Kirsling <ross.kirsl...@sony.com>
[WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
Modified: trunk/Tools/Scripts/webkitdirs.pm (231676 => 231677)
--- trunk/Tools/Scripts/webkitdirs.pm 2018-05-10 23:35:32 UTC (rev 231676)
+++ trunk/Tools/Scripts/webkitdirs.pm 2018-05-11 00:06:32 UTC (rev 231677)
@@ -230,7 +230,7 @@
{
return if defined $xcodeVersion;
my $xcodebuildVersionOutput = `xcodebuild -version`;
- $xcodeVersion = ($xcodebuildVersionOutput =~ /Xcode ([0-9](\.[0-9]+)*)/) ? $1 : "3.0";
+ $xcodeVersion = ($xcodebuildVersionOutput =~ /Xcode ([0-9]+(\.[0-9]+)*)/) ? $1 : "3.0";
}
sub readXcodeUserDefault($)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
