Title: [231706] trunk/LayoutTests
- Revision
- 231706
- Author
- [email protected]
- Date
- 2018-05-11 10:29:42 -0700 (Fri, 11 May 2018)
Log Message
Layout Test webrtc/addICECandidate-closed.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=185384
<rdar://problem/40035167>
Reviewed by Eric Carlson.
* webrtc/addICECandidate-closed.html: Move more pc calls inside the try/catch.
This ensures that the test will be consistent as the pc might be closed sooner for some runs.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (231705 => 231706)
--- trunk/LayoutTests/ChangeLog 2018-05-11 17:16:19 UTC (rev 231705)
+++ trunk/LayoutTests/ChangeLog 2018-05-11 17:29:42 UTC (rev 231706)
@@ -1,3 +1,14 @@
+2018-05-11 Youenn Fablet <[email protected]>
+
+ Layout Test webrtc/addICECandidate-closed.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=185384
+ <rdar://problem/40035167>
+
+ Reviewed by Eric Carlson.
+
+ * webrtc/addICECandidate-closed.html: Move more pc calls inside the try/catch.
+ This ensures that the test will be consistent as the pc might be closed sooner for some runs.
+
2018-05-11 Claudio Saavedra <[email protected]>
[GTK][a11y] Newly added accessibility/scroll-to-make-visible-iframe-offscreen.html fails
Modified: trunk/LayoutTests/webrtc/addICECandidate-closed.html (231705 => 231706)
--- trunk/LayoutTests/webrtc/addICECandidate-closed.html 2018-05-11 17:16:19 UTC (rev 231705)
+++ trunk/LayoutTests/webrtc/addICECandidate-closed.html 2018-05-11 17:29:42 UTC (rev 231706)
@@ -25,15 +25,15 @@
localTracks.forEach(track => sender.addTrack(track, stream));
receiver.addTransceiver('audio');
receiver.addTransceiver('video');
- const offer1 = await sender.createOffer();
- await sender.setLocalDescription(offer1);
- await receiver.setRemoteDescription(offer1);
- const answer1 = await receiver.createAnswer();
- await receiver.setLocalDescription(answer1);
await new Promise (async (resolve) => {
// RTCPeerConnection does not resolve promises when it gets closed, hence the timeout here to make sure we execute some if not all these operations.
test.step_timeout(resolve, 100);
try {
+ const offer1 = await sender.createOffer();
+ await sender.setLocalDescription(offer1);
+ await receiver.setRemoteDescription(offer1);
+ const answer1 = await receiver.createAnswer();
+ await receiver.setLocalDescription(answer1);
await sender.setRemoteDescription(answer1);
const offer2 = await sender.createOffer();
await sender.setLocalDescription(offer2);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
