Title: [231810] trunk/Source/WebKit
Revision
231810
Author
[email protected]
Date
2018-05-15 11:48:11 -0700 (Tue, 15 May 2018)

Log Message

Clear selections from web content with single tap
https://bugs.webkit.org/show_bug.cgi?id=185634

Reviewed by Tim Horton.
        
With the switch to the single text selection assistant, we were not correctly clearing the selection when a
single tap happened.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _singleTapCommited:]):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (231809 => 231810)


--- trunk/Source/WebKit/ChangeLog	2018-05-15 18:06:05 UTC (rev 231809)
+++ trunk/Source/WebKit/ChangeLog	2018-05-15 18:48:11 UTC (rev 231810)
@@ -1,3 +1,16 @@
+2018-05-15  Megan Gardner  <[email protected]>
+
+        Clear selections from web content with single tap
+        https://bugs.webkit.org/show_bug.cgi?id=185634
+
+        Reviewed by Tim Horton.
+        
+        With the switch to the single text selection assistant, we were not correctly clearing the selection when a
+        single tap happened.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView _singleTapCommited:]):
+
 2018-05-15  Antoine Quint  <[email protected]>
 
         [Web Animations] Expose Web Animations CSS integration as an experimental feature

Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (231809 => 231810)


--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2018-05-15 18:06:05 UTC (rev 231809)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2018-05-15 18:48:11 UTC (rev 231810)
@@ -1869,7 +1869,7 @@
     // The selection could have been set by autofocusing on page load and not
     // reflected in the UI process since the user was not interacting with the page.
     if (!_page->editorState().isContentEditable)
-        [_webSelectionAssistant clearSelection];
+        _page->clearSelection();
 
     _lastInteractionLocation = gestureRecognizer.location;
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to