Title: [231814] trunk/Source/WebKit
- Revision
- 231814
- Author
- [email protected]
- Date
- 2018-05-15 13:38:01 -0700 (Tue, 15 May 2018)
Log Message
Provide UIView and UIImage for zoom transition
https://bugs.webkit.org/show_bug.cgi?id=185655
<rdar://problem/40267224>
Reviewed by Antoine Quint.
Provide a UIView* for the frameForPreviewItem to use as a source view.
Also implement the transitionImageForPreviewItem delegate, even though
we're returning nil.
* UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
(-[_WKPreviewControllerDelegate previewController:frameForPreviewItem:inSourceView:]):
(-[_WKPreviewControllerDelegate previewController:transitionImageForPreviewItem:contentRect:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (231813 => 231814)
--- trunk/Source/WebKit/ChangeLog 2018-05-15 19:24:30 UTC (rev 231813)
+++ trunk/Source/WebKit/ChangeLog 2018-05-15 20:38:01 UTC (rev 231814)
@@ -1,3 +1,19 @@
+2018-05-15 Dean Jackson <[email protected]>
+
+ Provide UIView and UIImage for zoom transition
+ https://bugs.webkit.org/show_bug.cgi?id=185655
+ <rdar://problem/40267224>
+
+ Reviewed by Antoine Quint.
+
+ Provide a UIView* for the frameForPreviewItem to use as a source view.
+ Also implement the transitionImageForPreviewItem delegate, even though
+ we're returning nil.
+
+ * UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
+ (-[_WKPreviewControllerDelegate previewController:frameForPreviewItem:inSourceView:]):
+ (-[_WKPreviewControllerDelegate previewController:transitionImageForPreviewItem:contentRect:]):
+
2018-05-15 Daniel Bates <[email protected]>
Fix the Apple Internal build
Modified: trunk/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm (231813 => 231814)
--- trunk/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm 2018-05-15 19:24:30 UTC (rev 231813)
+++ trunk/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm 2018-05-15 20:38:01 UTC (rev 231814)
@@ -137,6 +137,7 @@
if (!presentingViewController)
return CGRectZero;
+ *view = presentingViewController.view;
CGRect frame = presentingViewController.view.frame;
// Create a smaller rectangle centered in the frame.
CGFloat halfWidth = frame.size.width / 2;
@@ -145,6 +146,11 @@
return frame;
}
+- (UIImage *)previewController:(QLPreviewController *)controller transitionImageForPreviewItem:(id <QLPreviewItem>)item contentRect:(CGRect *)contentRect
+{
+ return nil;
+}
+
@end
namespace WebKit {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
