Title: [231848] trunk/Tools
Revision
231848
Author
commit-qu...@webkit.org
Date
2018-05-16 09:11:09 -0700 (Wed, 16 May 2018)

Log Message

test262/Runner.pm: save to supplied expectation file if supplied
https://bugs.webkit.org/show_bug.cgi?id=185660

Patch by Valerie R Young <vale...@bocoup.com> on 2018-05-16
Reviewed by Michael Saboff.

* Scripts/test262/Runner.pm:
(processCLI):
(main):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (231847 => 231848)


--- trunk/Tools/ChangeLog	2018-05-16 14:51:39 UTC (rev 231847)
+++ trunk/Tools/ChangeLog	2018-05-16 16:11:09 UTC (rev 231848)
@@ -1,3 +1,14 @@
+2018-05-16  Valerie R Young  <vale...@bocoup.com>
+
+        test262/Runner.pm: save to supplied expectation file if supplied
+        https://bugs.webkit.org/show_bug.cgi?id=185660
+
+        Reviewed by Michael Saboff.
+
+        * Scripts/test262/Runner.pm:
+        (processCLI):
+        (main):
+
 2018-05-15  Ryan Haddad  <ryanhad...@apple.com>
 
         Unreviewed, rolling out r231763.

Modified: trunk/Tools/Scripts/test262/Runner.pm (231847 => 231848)


--- trunk/Tools/Scripts/test262/Runner.pm	2018-05-16 14:51:39 UTC (rev 231847)
+++ trunk/Tools/Scripts/test262/Runner.pm	2018-05-16 16:11:09 UTC (rev 231848)
@@ -208,10 +208,11 @@
             " please specify with --results.";
     }
 
-    if (! $ignoreExpectations && $specifiedExpectationsFile) {
+    if ($specifiedExpectationsFile) {
         $expectationsFile = abs_path($specifiedExpectationsFile);
-        if (! -e $expectationsFile) {
-            die "Error: Supplied expectations file $expectationsFile does not exist!";
+        if (! -e $expectationsFile && ! $ignoreExpectations) {
+            print("Warning: Supplied expectations file $expectationsFile does"
+                  . " not exist. Running tests without expectation file.\n");
         }
     }
 
@@ -389,7 +390,7 @@
     if ( !$expect ) {
         print $failcount . " tests failed\n";
     } else {
-        print $failcount . " expected tests failed\n";
+        print $failcount . " tests failed in total\n";
         print $newfailcount . " tests newly fail\n";
         print $newpasscount . " tests newly pass\n";
     }
@@ -927,7 +928,7 @@
 
 =item B<--expectations, -e>
 
-Specify a expectations file.  If not provided, script will load local JSTests/test262/expectations.yaml
+Specify a expectations file for loading and saving.  If not provided, script will load and save to JSTests/test262/expectations.yaml.
 
 =item B<--ignore-expectations, -x>
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to