Title: [231880] trunk/LayoutTests
- Revision
- 231880
- Author
- beid...@apple.com
- Date
- 2018-05-16 17:33:34 -0700 (Wed, 16 May 2018)
Log Message
LayoutTest storage/indexeddb/dont-wedge-private.html is a flaky failure
<rdar://problem/38975304> and https://bugs.webkit.org/show_bug.cgi?id=184058
Reviewed by Andy Estes.
Make the asynchronous IDB part of this test take way, way longer to always give the location change a chance to happen.
* TestExpectations:
* storage/indexeddb/dont-wedge-expected.txt:
* storage/indexeddb/dont-wedge-private-expected.txt:
* storage/indexeddb/resources/dont-wedge.js:
(openDatabase1.request.onupgradeneeded.openOnUpgradeNeeded1.putter):
(openDatabase1.request.onupgradeneeded):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (231879 => 231880)
--- trunk/LayoutTests/ChangeLog 2018-05-17 00:28:29 UTC (rev 231879)
+++ trunk/LayoutTests/ChangeLog 2018-05-17 00:33:34 UTC (rev 231880)
@@ -1,3 +1,19 @@
+2018-05-16 Brady Eidson <beid...@apple.com>
+
+ LayoutTest storage/indexeddb/dont-wedge-private.html is a flaky failure
+ <rdar://problem/38975304> and https://bugs.webkit.org/show_bug.cgi?id=184058
+
+ Reviewed by Andy Estes.
+
+ Make the asynchronous IDB part of this test take way, way longer to always give the location change a chance to happen.
+
+ * TestExpectations:
+ * storage/indexeddb/dont-wedge-expected.txt:
+ * storage/indexeddb/dont-wedge-private-expected.txt:
+ * storage/indexeddb/resources/dont-wedge.js:
+ (openDatabase1.request.onupgradeneeded.openOnUpgradeNeeded1.putter):
+ (openDatabase1.request.onupgradeneeded):
+
2018-05-16 Ross Kirsling <ross.kirsl...@sony.com>
[WinCairo] Unreviewed gardening before WinCairoRequirements update.
Modified: trunk/LayoutTests/TestExpectations (231879 => 231880)
--- trunk/LayoutTests/TestExpectations 2018-05-17 00:28:29 UTC (rev 231879)
+++ trunk/LayoutTests/TestExpectations 2018-05-17 00:33:34 UTC (rev 231880)
@@ -1896,8 +1896,6 @@
webkit.org/b/184198 imported/w3c/web-platform-tests/html/browsers/offline/appcache/workers/appcache-worker.html [ Pass Failure ]
-webkit.org/b/184058 storage/indexeddb/dont-wedge-private.html [ Pass Failure ]
-
webkit.org/b/184061 http/tests/appcache/interrupted-update.html [ Pass Failure ]
webkit.org/b/184453 imported/w3c/web-platform-tests/workers/name-property.html [ Pass Failure ]
Modified: trunk/LayoutTests/storage/indexeddb/dont-wedge-expected.txt (231879 => 231880)
--- trunk/LayoutTests/storage/indexeddb/dont-wedge-expected.txt 2018-05-17 00:28:29 UTC (rev 231879)
+++ trunk/LayoutTests/storage/indexeddb/dont-wedge-expected.txt 2018-05-17 00:33:34 UTC (rev 231880)
@@ -19,9 +19,6 @@
indexedDB.open(dbname1, 1)
openOnUpgradeNeeded1():
-db1 = event.target.result
-store1 = db1.createObjectStore('store')
-store1.put(0, 0)
openOnSuccess1():
PASS isAfterReload() is true
Modified: trunk/LayoutTests/storage/indexeddb/dont-wedge-private-expected.txt (231879 => 231880)
--- trunk/LayoutTests/storage/indexeddb/dont-wedge-private-expected.txt 2018-05-17 00:28:29 UTC (rev 231879)
+++ trunk/LayoutTests/storage/indexeddb/dont-wedge-private-expected.txt 2018-05-17 00:33:34 UTC (rev 231880)
@@ -19,9 +19,6 @@
indexedDB.open(dbname1, 1)
openOnUpgradeNeeded1():
-db1 = event.target.result
-store1 = db1.createObjectStore('store')
-store1.put(0, 0)
openOnSuccess1():
PASS isAfterReload() is true
Modified: trunk/LayoutTests/storage/indexeddb/resources/dont-wedge.js (231879 => 231880)
--- trunk/LayoutTests/storage/indexeddb/resources/dont-wedge.js 2018-05-17 00:28:29 UTC (rev 231879)
+++ trunk/LayoutTests/storage/indexeddb/resources/dont-wedge.js 2018-05-17 00:33:34 UTC (rev 231880)
@@ -54,9 +54,16 @@
request._onblocked_ = unexpectedBlockedCallback;
request._onupgradeneeded_ = function openOnUpgradeNeeded1(evt) {
preamble(evt);
- evalAndLog("db1 = event.target.result");
- evalAndLog("store1 = db1.createObjectStore('store')");
- evalAndLog("store1.put(0, 0)");
+ db1 = event.target.result;
+ store1 = db1.createObjectStore('store');
+ var count = 0;
+ function putter() {
+ ++count;
+ if (count == 50)
+ return;
+ store1.put(0, 0)._onsuccess_ = putter;
+ }
+ putter();
};
request._onsuccess_ = function openOnSuccess1(evt) {
preamble(evt);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
