Title: [232110] trunk
- Revision
- 232110
- Author
- [email protected]
- Date
- 2018-05-23 08:18:30 -0700 (Wed, 23 May 2018)
Log Message
Conversion misspelled "Convertion" in error message string
https://bugs.webkit.org/show_bug.cgi?id=185436
Patch by Rick Waldron <[email protected]> on 2018-05-23
JSTests:
Reviewed by Saam Barati, Michael Saboff.
* bigIntTests.yaml:
Source/_javascript_Core:
Reviewed by Saam Barati, Michael Saboff
* runtime/JSBigInt.cpp:
(JSC::JSBigInt::toNumber const):
Modified Paths
Added Paths
Diff
Modified: trunk/JSTests/ChangeLog (232109 => 232110)
--- trunk/JSTests/ChangeLog 2018-05-23 14:46:39 UTC (rev 232109)
+++ trunk/JSTests/ChangeLog 2018-05-23 15:18:30 UTC (rev 232110)
@@ -1,3 +1,12 @@
+2018-05-23 Rick Waldron <[email protected]>
+
+ Conversion misspelled "Convertion" in error message string
+ https://bugs.webkit.org/show_bug.cgi?id=185436
+
+ Reviewed by Saam Barati, Michael Saboff.
+
+ * bigIntTests.yaml:
+
2018-05-23 Yusuke Suzuki <[email protected]>
Unreviewed, skip test if memoryLimited is specified
Modified: trunk/JSTests/bigIntTests.yaml (232109 => 232110)
--- trunk/JSTests/bigIntTests.yaml 2018-05-23 14:46:39 UTC (rev 232109)
+++ trunk/JSTests/bigIntTests.yaml 2018-05-23 15:18:30 UTC (rev 232110)
@@ -135,3 +135,6 @@
- path: stress/big-int-division.js
cmd: runBigIntEnabled
+
+- path: stress/big-int-no-conversion-to-number.js
+ cmd: runBigIntEnabled
Added: trunk/JSTests/stress/big-int-no-conversion-to-number.js (0 => 232110)
--- trunk/JSTests/stress/big-int-no-conversion-to-number.js (rev 0)
+++ trunk/JSTests/stress/big-int-no-conversion-to-number.js 2018-05-23 15:18:30 UTC (rev 232110)
@@ -0,0 +1,12 @@
+//@ runBigIntEnabled
+
+let message;
+try {
+ 1n + 1;
+} catch (error) {
+ message = error.message;
+}
+
+if (message !== "Conversion from 'BigInt' to 'number' is not allowed.") {
+ throw new Error("Error message has changed to something unexpected");
+}
Modified: trunk/Source/_javascript_Core/ChangeLog (232109 => 232110)
--- trunk/Source/_javascript_Core/ChangeLog 2018-05-23 14:46:39 UTC (rev 232109)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-05-23 15:18:30 UTC (rev 232110)
@@ -1,3 +1,13 @@
+2018-05-23 Rick Waldron <[email protected]>
+
+ Conversion misspelled "Convertion" in error message string
+ https://bugs.webkit.org/show_bug.cgi?id=185436
+
+ Reviewed by Saam Barati, Michael Saboff
+
+ * runtime/JSBigInt.cpp:
+ (JSC::JSBigInt::toNumber const):
+
2018-05-22 Yusuke Suzuki <[email protected]>
[JSC] Clean up stringGetByValStubGenerator
Modified: trunk/Source/_javascript_Core/runtime/JSBigInt.cpp (232109 => 232110)
--- trunk/Source/_javascript_Core/runtime/JSBigInt.cpp 2018-05-23 14:46:39 UTC (rev 232109)
+++ trunk/Source/_javascript_Core/runtime/JSBigInt.cpp 2018-05-23 15:18:30 UTC (rev 232110)
@@ -1026,7 +1026,7 @@
{
VM& vm = state->vm();
auto scope = DECLARE_THROW_SCOPE(vm);
- throwTypeError(state, scope, ASCIILiteral("Convertion from 'BigInt' to 'number' is not allowed."));
+ throwTypeError(state, scope, ASCIILiteral("Conversion from 'BigInt' to 'number' is not allowed."));
return 0.0;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
