Title: [232144] trunk/LayoutTests
Revision
232144
Author
[email protected]
Date
2018-05-23 21:08:43 -0700 (Wed, 23 May 2018)

Log Message

Regression(r229831): fast/loader/_javascript_-url-iframe-remove-on-navigate-async-delegate.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=183885
<rdar://problem/38733968>

Reviewed by Youenn Fablet.

Stop loading an external URL as this is not what the test is testing and since the error message for
the external load causes flakiness.

* TestExpectations:
* fast/loader/_javascript_-url-iframe-remove-on-navigate-async-delegate-expected.txt:
* fast/loader/_javascript_-url-iframe-remove-on-navigate-async-delegate.html:
* fast/loader/_javascript_-url-iframe-remove-on-navigate-expected.txt:
* fast/loader/_javascript_-url-iframe-remove-on-navigate.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (232143 => 232144)


--- trunk/LayoutTests/ChangeLog	2018-05-24 03:01:43 UTC (rev 232143)
+++ trunk/LayoutTests/ChangeLog	2018-05-24 04:08:43 UTC (rev 232144)
@@ -1,5 +1,22 @@
 2018-05-23  Chris Dumez  <[email protected]>
 
+        Regression(r229831): fast/loader/_javascript_-url-iframe-remove-on-navigate-async-delegate.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=183885
+        <rdar://problem/38733968>
+
+        Reviewed by Youenn Fablet.
+
+        Stop loading an external URL as this is not what the test is testing and since the error message for
+        the external load causes flakiness.
+
+        * TestExpectations:
+        * fast/loader/_javascript_-url-iframe-remove-on-navigate-async-delegate-expected.txt:
+        * fast/loader/_javascript_-url-iframe-remove-on-navigate-async-delegate.html:
+        * fast/loader/_javascript_-url-iframe-remove-on-navigate-expected.txt:
+        * fast/loader/_javascript_-url-iframe-remove-on-navigate.html:
+
+2018-05-23  Chris Dumez  <[email protected]>
+
         RenderLayer::scrollRectToVisible() should not propagate a subframe's scroll to its cross-origin parent
         https://bugs.webkit.org/show_bug.cgi?id=185664
         <rdar://problem/36185260>

Modified: trunk/LayoutTests/TestExpectations (232143 => 232144)


--- trunk/LayoutTests/TestExpectations	2018-05-24 03:01:43 UTC (rev 232143)
+++ trunk/LayoutTests/TestExpectations	2018-05-24 04:08:43 UTC (rev 232144)
@@ -1976,10 +1976,6 @@
 
 media/event-queue-crash.html [ DumpJSConsoleLogInStdErr ]
 
-# This is flaky since r229831.
-webkit.org/b/183885 fast/loader/_javascript_-url-iframe-remove-on-navigate.html [ Pass Failure ]
-webkit.org/b/183885 fast/loader/_javascript_-url-iframe-remove-on-navigate-async-delegate.html [ Pass Failure ]
-
 webkit.org/b/172243 imported/w3c/web-platform-tests/IndexedDB/idbdatabase-createObjectStore-exception-order.htm [ Pass Failure ]
 
 webkit.org/b/179851 imported/w3c/web-platform-tests/html/browsers/offline/manifest_url_check.html [ Pass Failure ]

Modified: trunk/LayoutTests/fast/loader/_javascript_-url-iframe-remove-on-navigate-async-delegate-expected.txt (232143 => 232144)


--- trunk/LayoutTests/fast/loader/_javascript_-url-iframe-remove-on-navigate-async-delegate-expected.txt	2018-05-24 03:01:43 UTC (rev 232143)
+++ trunk/LayoutTests/fast/loader/_javascript_-url-iframe-remove-on-navigate-async-delegate-expected.txt	2018-05-24 04:08:43 UTC (rev 232144)
@@ -1,2 +1 @@
-Blocked access to external URL http://does.not.exist/
 PASS - _javascript_ URL blocked without crashing.

Modified: trunk/LayoutTests/fast/loader/_javascript_-url-iframe-remove-on-navigate-async-delegate.html (232143 => 232144)


--- trunk/LayoutTests/fast/loader/_javascript_-url-iframe-remove-on-navigate-async-delegate.html	2018-05-24 03:01:43 UTC (rev 232143)
+++ trunk/LayoutTests/fast/loader/_javascript_-url-iframe-remove-on-navigate-async-delegate.html	2018-05-24 04:08:43 UTC (rev 232144)
@@ -1,4 +1,4 @@
-<iframe src="" id="target"></iframe>
+<iframe src="" id="target"></iframe>
 <script>
 if (window.testRunner) {
     testRunner.dumpAsText();

Modified: trunk/LayoutTests/fast/loader/_javascript_-url-iframe-remove-on-navigate-expected.txt (232143 => 232144)


--- trunk/LayoutTests/fast/loader/_javascript_-url-iframe-remove-on-navigate-expected.txt	2018-05-24 03:01:43 UTC (rev 232143)
+++ trunk/LayoutTests/fast/loader/_javascript_-url-iframe-remove-on-navigate-expected.txt	2018-05-24 04:08:43 UTC (rev 232144)
@@ -1,2 +1 @@
-Blocked access to external URL http://does.not.exist/
 PASS - _javascript_ URL blocked without crashing.

Modified: trunk/LayoutTests/fast/loader/_javascript_-url-iframe-remove-on-navigate.html (232143 => 232144)


--- trunk/LayoutTests/fast/loader/_javascript_-url-iframe-remove-on-navigate.html	2018-05-24 03:01:43 UTC (rev 232143)
+++ trunk/LayoutTests/fast/loader/_javascript_-url-iframe-remove-on-navigate.html	2018-05-24 04:08:43 UTC (rev 232144)
@@ -1,4 +1,4 @@
-<iframe src="" id="target"></iframe>
+<iframe src="" id="target"></iframe>
 <script>
 if (window.testRunner) {
     testRunner.dumpAsText();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to