Title: [232162] trunk/Source/WebKit
- Revision
- 232162
- Author
- [email protected]
- Date
- 2018-05-24 13:33:17 -0700 (Thu, 24 May 2018)
Log Message
REGRESSION(r224908): [macOS] Media playback not honoring custom caption styles
https://bugs.webkit.org/show_bug.cgi?id=185955
<rdar://problem/40339278>
Reviewed by Eric Carlson.
In r224908 I removed access to the MediaAccessibility mach port, as well as
read/write access to various preferences associated with that process, as it
was no longer needed by modern WebKit media routines.
Detailed testing reveals that read access is still needed to these preferences
to properly handle custom caption styles.
This patch re-enables access to the media accessibility preferences.
* WebProcess/com.apple.WebProcess.sb.in:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (232161 => 232162)
--- trunk/Source/WebKit/ChangeLog 2018-05-24 19:44:42 UTC (rev 232161)
+++ trunk/Source/WebKit/ChangeLog 2018-05-24 20:33:17 UTC (rev 232162)
@@ -1,5 +1,24 @@
2018-05-24 Brent Fulgham <[email protected]>
+ REGRESSION(r224908): [macOS] Media playback not honoring custom caption styles
+ https://bugs.webkit.org/show_bug.cgi?id=185955
+ <rdar://problem/40339278>
+
+ Reviewed by Eric Carlson.
+
+ In r224908 I removed access to the MediaAccessibility mach port, as well as
+ read/write access to various preferences associated with that process, as it
+ was no longer needed by modern WebKit media routines.
+
+ Detailed testing reveals that read access is still needed to these preferences
+ to properly handle custom caption styles.
+
+ This patch re-enables access to the media accessibility preferences.
+
+ * WebProcess/com.apple.WebProcess.sb.in:
+
+2018-05-24 Brent Fulgham <[email protected]>
+
REGRESSION(r230269): ASSERTION FAILED: sendRightCount == 1 at ProcessLauncherMac.mm(218)
https://bugs.webkit.org/show_bug.cgi?id=185687
<rdar://problem/39386361>
Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (232161 => 232162)
--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2018-05-24 19:44:42 UTC (rev 232161)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2018-05-24 20:33:17 UTC (rev 232162)
@@ -477,6 +477,7 @@
"com.apple.driver.AppleBluetoothMultitouch.trackpad"
"com.apple.driver.AppleHIDMouse"
"com.apple.lookup.shared"
+ "com.apple.mediaaccessibility" ;; Needed for custom caption styles
"com.apple.networkConnect"
"com.apple.speech.voice.prefs"
"com.apple.systemsound"
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
