Title: [232179] trunk/Source/WebCore
Revision
232179
Author
[email protected]
Date
2018-05-24 18:58:14 -0700 (Thu, 24 May 2018)

Log Message

[iOS] Avoid dlopening QuickLooks in the common case where the main resource is HTML or plain text
https://bugs.webkit.org/show_bug.cgi?id=185966

Reviewed by Geoffrey Garen.

Avoid dlopening QuickLooks in the common case where the main resource is HTML or plain text
for performance reasons.

* loader/ios/PreviewLoader.mm:
(WebCore::PreviewLoader::shouldCreateForMIMEType):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (232178 => 232179)


--- trunk/Source/WebCore/ChangeLog	2018-05-25 01:42:36 UTC (rev 232178)
+++ trunk/Source/WebCore/ChangeLog	2018-05-25 01:58:14 UTC (rev 232179)
@@ -1,3 +1,16 @@
+2018-05-24  Chris Dumez  <[email protected]>
+
+        [iOS] Avoid dlopening QuickLooks in the common case where the main resource is HTML or plain text
+        https://bugs.webkit.org/show_bug.cgi?id=185966
+
+        Reviewed by Geoffrey Garen.
+
+        Avoid dlopening QuickLooks in the common case where the main resource is HTML or plain text
+        for performance reasons.
+
+        * loader/ios/PreviewLoader.mm:
+        (WebCore::PreviewLoader::shouldCreateForMIMEType):
+
 2018-05-24  Sam Weinig  <[email protected]>
 
         Modernize RenderStyleConstants.h - Part 2

Modified: trunk/Source/WebCore/loader/ios/PreviewLoader.mm (232178 => 232179)


--- trunk/Source/WebCore/loader/ios/PreviewLoader.mm	2018-05-25 01:42:36 UTC (rev 232178)
+++ trunk/Source/WebCore/loader/ios/PreviewLoader.mm	2018-05-25 01:58:14 UTC (rev 232179)
@@ -243,6 +243,9 @@
 
 bool PreviewLoader::shouldCreateForMIMEType(const String& mimeType)
 {
+    if (equalLettersIgnoringASCIICase(mimeType, "text/html") || equalLettersIgnoringASCIICase(mimeType, "text/plain"))
+        return false;
+
     static std::once_flag onceFlag;
     static NeverDestroyed<HashSet<String, ASCIICaseInsensitiveHash>> supportedMIMETypes;
     std::call_once(onceFlag, [] {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to