Title: [232184] trunk/Source/WebKit
- Revision
- 232184
- Author
- [email protected]
- Date
- 2018-05-24 22:09:33 -0700 (Thu, 24 May 2018)
Log Message
ProcessLauncherMac.mm contains a couple of meaningless #ifndef directives
https://bugs.webkit.org/show_bug.cgi?id=185973
Reviewed by Tim Horton.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): Use #if !ASSERT_DISABLED to guard statements that
are only needed for an assertion, instead of #ifndef _NDEBUG, which is always true.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (232183 => 232184)
--- trunk/Source/WebKit/ChangeLog 2018-05-25 04:59:07 UTC (rev 232183)
+++ trunk/Source/WebKit/ChangeLog 2018-05-25 05:09:33 UTC (rev 232184)
@@ -1,3 +1,14 @@
+2018-05-24 Dan Bernstein <[email protected]>
+
+ ProcessLauncherMac.mm contains a couple of meaningless #ifndef directives
+ https://bugs.webkit.org/show_bug.cgi?id=185973
+
+ Reviewed by Tim Horton.
+
+ * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+ (WebKit::ProcessLauncher::launchProcess): Use #if !ASSERT_DISABLED to guard statements that
+ are only needed for an assertion, instead of #ifndef _NDEBUG, which is always true.
+
2018-05-24 Carlos Alberto Lopez Perez <[email protected]>
[GTK][WPE] Memory pressure monitor doesn't reliable notify all the subprocesses
Modified: trunk/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm (232183 => 232184)
--- trunk/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm 2018-05-25 04:59:07 UTC (rev 232183)
+++ trunk/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm 2018-05-25 05:09:33 UTC (rev 232184)
@@ -212,7 +212,7 @@
if (!processLauncher->isLaunching())
return;
-#ifndef _NDEBUG
+#if !ASSERT_DISABLED
mach_port_urefs_t sendRightCount = 0;
mach_port_get_refs(mach_task_self(), listeningPort, MACH_PORT_RIGHT_SEND, &sendRightCount);
ASSERT(sendRightCount >= 1);
@@ -249,7 +249,7 @@
ASSERT(xpc_get_type(reply) == XPC_TYPE_DICTIONARY);
ASSERT(!strcmp(xpc_dictionary_get_string(reply, "message-name"), "process-finished-launching"));
-#ifndef _NDEBUG
+#if !ASSERT_DISABLED
mach_port_urefs_t sendRightCount = 0;
mach_port_get_refs(mach_task_self(), listeningPort, MACH_PORT_RIGHT_SEND, &sendRightCount);
ASSERT(sendRightCount >= 1);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
