Title: [232207] trunk/Source/WebCore
- Revision
- 232207
- Author
- [email protected]
- Date
- 2018-05-25 14:49:01 -0700 (Fri, 25 May 2018)
Log Message
Use correct AVKit delegate for picture in picture failure.
https://bugs.webkit.org/show_bug.cgi?id=185981
rdar://problem/40549652
Patch by Jeremy Jones <[email protected]> on 2018-05-25
Reviewed by Eric Carlson.
No new tests since we don't have a way to simulate picture-in-picture failure.
Use the new name for this delegate callback.
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerViewControllerDelegate playerViewController:failedToStartPictureInPictureWithError:]):
(-[WebAVPlayerViewControllerDelegate playerViewControllerFailedToStartPictureInPicture:withError:]): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (232206 => 232207)
--- trunk/Source/WebCore/ChangeLog 2018-05-25 21:42:52 UTC (rev 232206)
+++ trunk/Source/WebCore/ChangeLog 2018-05-25 21:49:01 UTC (rev 232207)
@@ -1,3 +1,19 @@
+2018-05-25 Jeremy Jones <[email protected]>
+
+ Use correct AVKit delegate for picture in picture failure.
+ https://bugs.webkit.org/show_bug.cgi?id=185981
+ rdar://problem/40549652
+
+ Reviewed by Eric Carlson.
+
+ No new tests since we don't have a way to simulate picture-in-picture failure.
+
+ Use the new name for this delegate callback.
+
+ * platform/ios/VideoFullscreenInterfaceAVKit.mm:
+ (-[WebAVPlayerViewControllerDelegate playerViewController:failedToStartPictureInPictureWithError:]):
+ (-[WebAVPlayerViewControllerDelegate playerViewControllerFailedToStartPictureInPicture:withError:]): Deleted.
+
2018-05-25 Zalan Bujtas <[email protected]>
iBooks: text can disappear/flash during finger drag highlight
Modified: trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm (232206 => 232207)
--- trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2018-05-25 21:42:52 UTC (rev 232206)
+++ trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2018-05-25 21:49:01 UTC (rev 232207)
@@ -134,7 +134,7 @@
self.fullscreenInterface->didStartPictureInPicture();
}
-- (void)playerViewControllerFailedToStartPictureInPicture:(AVPlayerViewController *)playerViewController withError:(NSError *)error
+- (void)playerViewController:(AVPlayerViewController *)playerViewController failedToStartPictureInPictureWithError:(NSError *)error
{
UNUSED_PARAM(playerViewController);
UNUSED_PARAM(error);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
