Title: [232266] trunk/Source/WebKit
- Revision
- 232266
- Author
- [email protected]
- Date
- 2018-05-29 11:10:55 -0700 (Tue, 29 May 2018)
Log Message
Expose additional WKMenuItemIdentifier strings
https://bugs.webkit.org/show_bug.cgi?id=186041
Reviewed by Dan Bernstein.
Expose identifiers for media-related menu items.
* UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm:
Define new identifiers.
* UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h:
Declare new identifiers.
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::menuItemIdentifier):
Map to new identifiers.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (232265 => 232266)
--- trunk/Source/WebKit/ChangeLog 2018-05-29 18:10:50 UTC (rev 232265)
+++ trunk/Source/WebKit/ChangeLog 2018-05-29 18:10:55 UTC (rev 232266)
@@ -1,3 +1,22 @@
+2018-05-28 Jeff Miller <[email protected]>
+
+ Expose additional WKMenuItemIdentifier strings
+ https://bugs.webkit.org/show_bug.cgi?id=186041
+
+ Reviewed by Dan Bernstein.
+
+ Expose identifiers for media-related menu items.
+
+ * UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm:
+ Define new identifiers.
+
+ * UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h:
+ Declare new identifiers.
+
+ * UIProcess/mac/WebContextMenuProxyMac.mm:
+ (WebKit::menuItemIdentifier):
+ Map to new identifiers.
+
2018-05-29 Geoffrey Garen <[email protected]>
Removed some unused WebSQL trackers
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm (232265 => 232266)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm 2018-05-29 18:10:50 UTC (rev 232265)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm 2018-05-29 18:10:55 UTC (rev 232266)
@@ -31,8 +31,10 @@
NSString * const _WKMenuItemIdentifierCopy = @"WKMenuItemIdentifierCopy";
NSString * const _WKMenuItemIdentifierCopyImage = @"WKMenuItemIdentifierCopyImage";
NSString * const _WKMenuItemIdentifierCopyLink = @"WKMenuItemIdentifierCopyLink";
+NSString * const _WKMenuItemIdentifierCopyMediaLink = @"WKMenuItemIdentifierCopyMediaLink";
NSString * const _WKMenuItemIdentifierDownloadImage = @"WKMenuItemIdentifierDownloadImage";
NSString * const _WKMenuItemIdentifierDownloadLinkedFile = @"WKMenuItemIdentifierDownloadLinkedFile";
+NSString * const _WKMenuItemIdentifierDownloadMedia = @"WKMenuItemIdentifierDownloadMedia";
NSString * const _WKMenuItemIdentifierGoBack = @"WKMenuItemIdentifierGoBack";
NSString * const _WKMenuItemIdentifierGoForward = @"WKMenuItemIdentifierGoForward";
NSString * const _WKMenuItemIdentifierInspectElement = @"WKMenuItemIdentifierInspectElement";
@@ -41,10 +43,12 @@
NSString * const _WKMenuItemIdentifierOpenImageInNewWindow = @"WKMenuItemIdentifierOpenImageInNewWindow";
NSString * const _WKMenuItemIdentifierOpenLink = @"WKMenuItemIdentifierOpenLink";
NSString * const _WKMenuItemIdentifierOpenLinkInNewWindow = @"WKMenuItemIdentifierOpenLinkInNewWindow";
+NSString * const _WKMenuItemIdentifierOpenMediaInNewWindow = @"WKMenuItemIdentifierOpenMediaInNewWindow";
NSString * const _WKMenuItemIdentifierPaste = @"WKMenuItemIdentifierPaste";
NSString * const _WKMenuItemIdentifierReload = @"WKMenuItemIdentifierReload";
NSString * const _WKMenuItemIdentifierSearchWeb = @"WKMenuItemIdentifierSearchWeb";
NSString * const _WKMenuItemIdentifierShowHideMediaControls = @"WKMenuItemIdentifierShowHideMediaControls";
+NSString * const _WKMenuItemIdentifierToggleEnhancedFullScreen = @"WKMenuItemIdentifierToggleEnhancedFullScreen";
NSString * const _WKMenuItemIdentifierToggleFullScreen = @"WKMenuItemIdentifierToggleFullScreen";
NSString * const _WKMenuItemIdentifierShareMenu = @"WKMenuItemIdentifierShareMenu";
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h (232265 => 232266)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h 2018-05-29 18:10:50 UTC (rev 232265)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h 2018-05-29 18:10:55 UTC (rev 232266)
@@ -33,8 +33,10 @@
WK_EXPORT extern NSString * const _WKMenuItemIdentifierCopy WK_API_AVAILABLE(macosx(10.12), ios(10.0));
WK_EXPORT extern NSString * const _WKMenuItemIdentifierCopyImage WK_API_AVAILABLE(macosx(10.12), ios(10.0));
WK_EXPORT extern NSString * const _WKMenuItemIdentifierCopyLink WK_API_AVAILABLE(macosx(10.12), ios(10.0));
+WK_EXPORT extern NSString * const _WKMenuItemIdentifierCopyMediaLink WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
WK_EXPORT extern NSString * const _WKMenuItemIdentifierDownloadImage WK_API_AVAILABLE(macosx(10.12), ios(10.0));
WK_EXPORT extern NSString * const _WKMenuItemIdentifierDownloadLinkedFile WK_API_AVAILABLE(macosx(10.12), ios(10.0));
+WK_EXPORT extern NSString * const _WKMenuItemIdentifierDownloadMedia WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
WK_EXPORT extern NSString * const _WKMenuItemIdentifierGoBack WK_API_AVAILABLE(macosx(10.12), ios(10.0));
WK_EXPORT extern NSString * const _WKMenuItemIdentifierGoForward WK_API_AVAILABLE(macosx(10.12), ios(10.0));
WK_EXPORT extern NSString * const _WKMenuItemIdentifierInspectElement WK_API_AVAILABLE(macosx(10.12), ios(10.0));
@@ -43,10 +45,12 @@
WK_EXPORT extern NSString * const _WKMenuItemIdentifierOpenImageInNewWindow WK_API_AVAILABLE(macosx(10.12), ios(10.0));
WK_EXPORT extern NSString * const _WKMenuItemIdentifierOpenLink WK_API_AVAILABLE(macosx(10.12), ios(10.0));
WK_EXPORT extern NSString * const _WKMenuItemIdentifierOpenLinkInNewWindow WK_API_AVAILABLE(macosx(10.12), ios(10.0));
+WK_EXPORT extern NSString * const _WKMenuItemIdentifierOpenMediaInNewWindow WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
WK_EXPORT extern NSString * const _WKMenuItemIdentifierPaste WK_API_AVAILABLE(macosx(10.12), ios(10.0));
WK_EXPORT extern NSString * const _WKMenuItemIdentifierReload WK_API_AVAILABLE(macosx(10.12), ios(10.0));
WK_EXPORT extern NSString * const _WKMenuItemIdentifierSearchWeb WK_API_AVAILABLE(macosx(10.12), ios(10.0));
WK_EXPORT extern NSString * const _WKMenuItemIdentifierShowHideMediaControls WK_API_AVAILABLE(macosx(10.12), ios(10.0));
+WK_EXPORT extern NSString * const _WKMenuItemIdentifierToggleEnhancedFullScreen WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
WK_EXPORT extern NSString * const _WKMenuItemIdentifierToggleFullScreen WK_API_AVAILABLE(macosx(10.12), ios(10.0));
WK_EXPORT extern NSString * const _WKMenuItemIdentifierShareMenu WK_API_AVAILABLE(macosx(10.12), ios(10.0));
Modified: trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm (232265 => 232266)
--- trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm 2018-05-29 18:10:50 UTC (rev 232265)
+++ trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm 2018-05-29 18:10:55 UTC (rev 232266)
@@ -354,6 +354,9 @@
case ContextMenuItemTagCopyLinkToClipboard:
return _WKMenuItemIdentifierCopyLink;
+ case ContextMenuItemTagCopyMediaLinkToClipboard:
+ return _WKMenuItemIdentifierCopyMediaLink;
+
case ContextMenuItemTagDownloadImageToDisk:
return _WKMenuItemIdentifierDownloadImage;
@@ -360,6 +363,9 @@
case ContextMenuItemTagDownloadLinkToDisk:
return _WKMenuItemIdentifierDownloadLinkedFile;
+ case ContextMenuItemTagDownloadMediaToDisk:
+ return _WKMenuItemIdentifierDownloadMedia;
+
case ContextMenuItemTagGoBack:
return _WKMenuItemIdentifierGoBack;
@@ -384,6 +390,9 @@
case ContextMenuItemTagOpenLinkInNewWindow:
return _WKMenuItemIdentifierOpenLinkInNewWindow;
+ case ContextMenuItemTagOpenMediaInNewWindow:
+ return _WKMenuItemIdentifierOpenMediaInNewWindow;
+
case ContextMenuItemTagPaste:
return _WKMenuItemIdentifierPaste;
@@ -396,6 +405,9 @@
case ContextMenuItemTagToggleMediaControls:
return _WKMenuItemIdentifierShowHideMediaControls;
+ case ContextMenuItemTagToggleVideoEnhancedFullscreen:
+ return _WKMenuItemIdentifierToggleEnhancedFullScreen;
+
case ContextMenuItemTagToggleVideoFullscreen:
return _WKMenuItemIdentifierToggleFullScreen;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
