Title: [232307] trunk/Source/WebKit
- Revision
- 232307
- Author
- [email protected]
- Date
- 2018-05-30 13:37:50 -0700 (Wed, 30 May 2018)
Log Message
Take a background process assertion in WebPageProxy::callAfterNextPresentationUpdate()
https://bugs.webkit.org/show_bug.cgi?id=186097
<rdar://problem/40651225>
Reviewed by Dan Bernstein.
Refactor fix landed in r232298 so that we rely on the existing Callback infrastructure
to take a background process assertion.
* UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::dispatchAfterEnsuringDrawing):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::callAfterNextPresentationUpdate):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (232306 => 232307)
--- trunk/Source/WebKit/ChangeLog 2018-05-30 20:35:11 UTC (rev 232306)
+++ trunk/Source/WebKit/ChangeLog 2018-05-30 20:37:50 UTC (rev 232307)
@@ -1,3 +1,19 @@
+2018-05-30 Chris Dumez <[email protected]>
+
+ Take a background process assertion in WebPageProxy::callAfterNextPresentationUpdate()
+ https://bugs.webkit.org/show_bug.cgi?id=186097
+ <rdar://problem/40651225>
+
+ Reviewed by Dan Bernstein.
+
+ Refactor fix landed in r232298 so that we rely on the existing Callback infrastructure
+ to take a background process assertion.
+
+ * UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
+ (WebKit::RemoteLayerTreeDrawingAreaProxy::dispatchAfterEnsuringDrawing):
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::callAfterNextPresentationUpdate):
+
2018-05-30 Aditya Keerthi <[email protected]>
Fix the ENABLE(DATALIST_ELEMENT) build
Modified: trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm (232306 => 232307)
--- trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm 2018-05-30 20:35:11 UTC (rev 232306)
+++ trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm 2018-05-30 20:37:50 UTC (rev 232307)
@@ -456,7 +456,7 @@
return;
}
- m_webPageProxy.process().send(Messages::DrawingArea::AddTransactionCallbackID(m_callbacks.put(WTFMove(callbackFunction), nullptr)), m_webPageProxy.pageID());
+ m_webPageProxy.process().send(Messages::DrawingArea::AddTransactionCallbackID(m_callbacks.put(WTFMove(callbackFunction), m_webPageProxy.process().throttler().backgroundActivityToken())), m_webPageProxy.pageID());
}
void RemoteLayerTreeDrawingAreaProxy::hideContentUntilPendingUpdate()
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (232306 => 232307)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-05-30 20:35:11 UTC (rev 232306)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-05-30 20:37:50 UTC (rev 232307)
@@ -7351,9 +7351,7 @@
return;
}
- m_drawingArea->dispatchAfterEnsuringDrawing([callback = WTFMove(callback), backgroundActivity = m_process->throttler().backgroundActivityToken()](CallbackBase::Error error) {
- callback(error);
- });
+ m_drawingArea->dispatchAfterEnsuringDrawing(WTFMove(callback));
}
void WebPageProxy::setShouldScaleViewToFitDocument(bool shouldScaleViewToFitDocument)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
