Title: [232308] trunk/Source/WebKit
- Revision
- 232308
- Author
- [email protected]
- Date
- 2018-05-30 13:41:07 -0700 (Wed, 30 May 2018)
Log Message
[iOS] -[WKFullScreenViewController viewWillAppear:] should call [super viewWillAppeear:]
<https://webkit.org/b/186103>
<rdar://problem/40655695>
Reviewed by Eric Carlson.
* UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(WKFullScreenViewControllerPlaybackSessionModelClient::setInterface):
Drive-by clean up. For consistency, we always use the same
variable in the body of the `if` statement that was used in the
condition.
(-[WKFullScreenViewController viewWillAppear:]): Call
[super viewWillAppeear:] to fulfill API contract.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (232307 => 232308)
--- trunk/Source/WebKit/ChangeLog 2018-05-30 20:37:50 UTC (rev 232307)
+++ trunk/Source/WebKit/ChangeLog 2018-05-30 20:41:07 UTC (rev 232308)
@@ -1,3 +1,19 @@
+2018-05-30 David Kilzer <[email protected]>
+
+ [iOS] -[WKFullScreenViewController viewWillAppear:] should call [super viewWillAppeear:]
+ <https://webkit.org/b/186103>
+ <rdar://problem/40655695>
+
+ Reviewed by Eric Carlson.
+
+ * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
+ (WKFullScreenViewControllerPlaybackSessionModelClient::setInterface):
+ Drive-by clean up. For consistency, we always use the same
+ variable in the body of the `if` statement that was used in the
+ condition.
+ (-[WKFullScreenViewController viewWillAppear:]): Call
+ [super viewWillAppeear:] to fulfill API contract.
+
2018-05-30 Chris Dumez <[email protected]>
Take a background process assertion in WebPageProxy::callAfterNextPresentationUpdate()
Modified: trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm (232307 => 232308)
--- trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm 2018-05-30 20:37:50 UTC (rev 232307)
+++ trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm 2018-05-30 20:41:07 UTC (rev 232308)
@@ -70,7 +70,7 @@
m_interface->playbackSessionModel()->removeClient(*this);
m_interface = interface;
if (m_interface && m_interface->playbackSessionModel())
- interface->playbackSessionModel()->addClient(*this);
+ m_interface->playbackSessionModel()->addClient(*this);
}
private:
@@ -303,6 +303,8 @@
if (auto* manager = self._manager)
manager->setFullscreenAutoHideDelay(autoHideDelay);
+
+ [super viewWillAppear:animated];
}
- (void)viewDidLayoutSubviews
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
