Title: [232349] trunk/Source/WebCore
- Revision
- 232349
- Author
- [email protected]
- Date
- 2018-05-31 09:24:59 -0700 (Thu, 31 May 2018)
Log Message
Unreviewed iOS build fix after r232335.
* html/BaseChooserOnlyDateAndTimeInputType.h:
* html/BaseDateAndTimeInputType.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (232348 => 232349)
--- trunk/Source/WebCore/ChangeLog 2018-05-31 15:47:35 UTC (rev 232348)
+++ trunk/Source/WebCore/ChangeLog 2018-05-31 16:24:59 UTC (rev 232349)
@@ -1,5 +1,12 @@
2018-05-31 Chris Dumez <[email protected]>
+ Unreviewed iOS build fix after r232335.
+
+ * html/BaseChooserOnlyDateAndTimeInputType.h:
+ * html/BaseDateAndTimeInputType.h:
+
+2018-05-31 Chris Dumez <[email protected]>
+
Unreviewed, apply review comments from Darin after r232310.
* platform/ReferrerPolicy.cpp:
Modified: trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h (232348 => 232349)
--- trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h 2018-05-31 15:47:35 UTC (rev 232348)
+++ trunk/Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h 2018-05-31 16:24:59 UTC (rev 232349)
@@ -35,13 +35,13 @@
namespace WebCore {
-class BaseChooserOnlyDateAndTimeInputType : protected BaseDateAndTimeInputType, private DateTimeChooserClient {
+class BaseChooserOnlyDateAndTimeInputType : public BaseDateAndTimeInputType, private DateTimeChooserClient {
protected:
explicit BaseChooserOnlyDateAndTimeInputType(HTMLInputElement& element) : BaseDateAndTimeInputType(element) { }
~BaseChooserOnlyDateAndTimeInputType();
private:
- void updateInnerTextValue();
+ void updateInnerTextValue() override;
void closeDateTimeChooser();
// InputType functions:
Modified: trunk/Source/WebCore/html/BaseDateAndTimeInputType.h (232348 => 232349)
--- trunk/Source/WebCore/html/BaseDateAndTimeInputType.h 2018-05-31 15:47:35 UTC (rev 232348)
+++ trunk/Source/WebCore/html/BaseDateAndTimeInputType.h 2018-05-31 16:24:59 UTC (rev 232349)
@@ -50,6 +50,7 @@
String serializeWithComponents(const DateComponents&) const;
virtual bool setMillisecondToDateComponents(double, DateComponents*) const = 0;
String visibleValue() const override;
+ void attributeChanged(const QualifiedName&) override;
#if PLATFORM(IOS)
bool isKeyboardFocusable(KeyboardEvent*) const override;
#endif
@@ -67,7 +68,6 @@
bool typeMismatch() const override;
bool valueMissing(const String&) const override;
Decimal defaultValueForStepUp() const override;
- void attributeChanged(const QualifiedName&) override;
bool isSteppable() const override;
virtual String serializeWithMilliseconds(double) const;
String localizeValue(const String&) const override;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
