Title: [232354] trunk/Source/WebCore
Revision
232354
Author
[email protected]
Date
2018-05-31 10:38:59 -0700 (Thu, 31 May 2018)

Log Message

Fix memory leak under NetworkStateNotifier::updateStateWithoutNotifying()
https://bugs.webkit.org/show_bug.cgi?id=186149
<rdar://problem/40674537>

Reviewed by Geoffrey Garen.

* platform/network/mac/NetworkStateNotifierMac.cpp:
(WebCore::NetworkStateNotifier::updateStateWithoutNotifying):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (232353 => 232354)


--- trunk/Source/WebCore/ChangeLog	2018-05-31 16:58:45 UTC (rev 232353)
+++ trunk/Source/WebCore/ChangeLog	2018-05-31 17:38:59 UTC (rev 232354)
@@ -1,3 +1,14 @@
+2018-05-31  Chris Dumez  <[email protected]>
+
+        Fix memory leak under NetworkStateNotifier::updateStateWithoutNotifying()
+        https://bugs.webkit.org/show_bug.cgi?id=186149
+        <rdar://problem/40674537>
+
+        Reviewed by Geoffrey Garen.
+
+        * platform/network/mac/NetworkStateNotifierMac.cpp:
+        (WebCore::NetworkStateNotifier::updateStateWithoutNotifying):
+
 2018-05-31  Zalan Bujtas  <[email protected]>
 
         [LFC] Layout code needs to know the type of the Element associated with a Layout::Box

Modified: trunk/Source/WebCore/platform/network/mac/NetworkStateNotifierMac.cpp (232353 => 232354)


--- trunk/Source/WebCore/platform/network/mac/NetworkStateNotifierMac.cpp	2018-05-31 16:58:45 UTC (rev 232353)
+++ trunk/Source/WebCore/platform/network/mac/NetworkStateNotifierMac.cpp	2018-05-31 17:38:59 UTC (rev 232354)
@@ -61,7 +61,7 @@
             continue;
 
         auto key = adoptCF(SCDynamicStoreKeyCreateNetworkInterfaceEntity(0, kSCDynamicStoreDomainState, interfaceName, kSCEntNetIPv4));
-        if (SCDynamicStoreCopyValue(m_store.get(), key.get())) {
+        if (auto value = adoptCF(SCDynamicStoreCopyValue(m_store.get(), key.get()))) {
             m_isOnLine = true;
             return;
         }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to