Title: [232409] trunk/LayoutTests
- Revision
- 232409
- Author
- [email protected]
- Date
- 2018-06-01 12:53:56 -0700 (Fri, 01 Jun 2018)
Log Message
http/tests/appcache/deferred-events.html is flaky due to console log messages
https://bugs.webkit.org/show_bug.cgi?id=185543
Reviewed by Chris Dumez.
Update the test to wait for the onerror callback.
At that time, all console logging should be done.
* http/tests/appcache/deferred-events-expected.txt:
* http/tests/appcache/deferred-events.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (232408 => 232409)
--- trunk/LayoutTests/ChangeLog 2018-06-01 19:41:14 UTC (rev 232408)
+++ trunk/LayoutTests/ChangeLog 2018-06-01 19:53:56 UTC (rev 232409)
@@ -1,3 +1,16 @@
+2018-06-01 Youenn Fablet <[email protected]>
+
+ http/tests/appcache/deferred-events.html is flaky due to console log messages
+ https://bugs.webkit.org/show_bug.cgi?id=185543
+
+ Reviewed by Chris Dumez.
+
+ Update the test to wait for the onerror callback.
+ At that time, all console logging should be done.
+
+ * http/tests/appcache/deferred-events-expected.txt:
+ * http/tests/appcache/deferred-events.html:
+
2018-05-29 Yusuke Suzuki <[email protected]>
[JSC] Add Symbol.prototype.description getter
Modified: trunk/LayoutTests/http/tests/appcache/deferred-events-expected.txt (232408 => 232409)
--- trunk/LayoutTests/http/tests/appcache/deferred-events-expected.txt 2018-06-01 19:41:14 UTC (rev 232408)
+++ trunk/LayoutTests/http/tests/appcache/deferred-events-expected.txt 2018-06-01 19:53:56 UTC (rev 232409)
@@ -1,4 +1,4 @@
CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response.
Test that AppicationCache events are deferred until after onload has been fired.
-SUCCESS
+PASS
Modified: trunk/LayoutTests/http/tests/appcache/deferred-events.html (232408 => 232409)
--- trunk/LayoutTests/http/tests/appcache/deferred-events.html 2018-06-01 19:41:14 UTC (rev 232408)
+++ trunk/LayoutTests/http/tests/appcache/deferred-events.html 2018-06-01 19:53:56 UTC (rev 232409)
@@ -2,6 +2,7 @@
<head>
<script type="text/_javascript_">
var _onloadHasBeenCalled_ = false;
+ var _oncheckingAfterOnload_ = false;
if (window.testRunner) {
testRunner.dumpAsText()
@@ -9,11 +10,20 @@
}
window.applicationCache._onchecking_ = function() {
- if (onloadHasBeenCalled)
- document.getElementById('result').innerHTML = "SUCCESS"
+ _oncheckingAfterOnload_ = onloadHasBeenCalled;
+ }
+
+ window.applicationCache._onerror_ = function() {
+ document.getElementById('result').innerHTML = oncheckingAfterOnload ? "PASS" : "FAIL";
if (window.testRunner)
testRunner.notifyDone();
}
+
+ window.applicationCache._oncached_ = function() {
+ document.getElementById('result').innerHTML = "FAIL: oncached event received";
+ if (window.testRunner)
+ testRunner.notifyDone();
+ }
</script>
<script src="" type="text/_javascript_"></script>
</head>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
