Title: [232426] trunk/Source/WebCore
- Revision
- 232426
- Author
- [email protected]
- Date
- 2018-06-01 16:19:58 -0700 (Fri, 01 Jun 2018)
Log Message
Don't continue playing in background when auto-picture-in-picture is disabled.
https://bugs.webkit.org/show_bug.cgi?id=186089
rdar://problem/40314314
Patch by Jeremy Jones <[email protected]> on 2018-06-01
Reviewed by Eric Carlson.
No new tests because we don't have a way to test auto-pip.
With the refactoring work done in VideoFullscreenInterfaceAVKit, HTMLMediaElement no longer has to anticipate
auto-pip when if it should pause on suspend. Instead VideoFullscreenInterfaceAVKit proactively updates
videoFullscreenMode, so checking for PIP is sufficient.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (232425 => 232426)
--- trunk/Source/WebCore/ChangeLog 2018-06-01 23:15:16 UTC (rev 232425)
+++ trunk/Source/WebCore/ChangeLog 2018-06-01 23:19:58 UTC (rev 232426)
@@ -1,3 +1,20 @@
+2018-06-01 Jeremy Jones <[email protected]>
+
+ Don't continue playing in background when auto-picture-in-picture is disabled.
+ https://bugs.webkit.org/show_bug.cgi?id=186089
+ rdar://problem/40314314
+
+ Reviewed by Eric Carlson.
+
+ No new tests because we don't have a way to test auto-pip.
+
+ With the refactoring work done in VideoFullscreenInterfaceAVKit, HTMLMediaElement no longer has to anticipate
+ auto-pip when if it should pause on suspend. Instead VideoFullscreenInterfaceAVKit proactively updates
+ videoFullscreenMode, so checking for PIP is sufficient.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction const):
+
2018-06-01 Chris Dumez <[email protected]>
REGRESSION (r231456): Colloquy is broken
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (232425 => 232426)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2018-06-01 23:15:16 UTC (rev 232425)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2018-06-01 23:19:58 UTC (rev 232426)
@@ -7544,7 +7544,7 @@
#endif
if (m_videoFullscreenMode & VideoFullscreenModePictureInPicture)
return true;
-#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
+#if PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE)
if (((m_videoFullscreenMode == VideoFullscreenModeStandard) || m_videoFullscreenStandby) && supportsPictureInPicture() && isPlaying())
return true;
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
