Title: [232438] trunk/Source/WebKit
- Revision
- 232438
- Author
- [email protected]
- Date
- 2018-06-02 09:03:31 -0700 (Sat, 02 Jun 2018)
Log Message
Make WKWebView firstResponder after entering or exiting fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=186088
rdar://problem/40387859
Patch by Jeremy Jones <[email protected]> on 2018-06-02
Reviewed by Jer Noble.
Update first responder when WKWebView moves to a new window, otherwise there won't be a first responder.
* UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController _completedExitFullScreen]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (232437 => 232438)
--- trunk/Source/WebKit/ChangeLog 2018-06-02 16:02:14 UTC (rev 232437)
+++ trunk/Source/WebKit/ChangeLog 2018-06-02 16:03:31 UTC (rev 232438)
@@ -1,5 +1,19 @@
2018-06-02 Jeremy Jones <[email protected]>
+ Make WKWebView firstResponder after entering or exiting fullscreen.
+ https://bugs.webkit.org/show_bug.cgi?id=186088
+ rdar://problem/40387859
+
+ Reviewed by Jer Noble.
+
+ Update first responder when WKWebView moves to a new window, otherwise there won't be a first responder.
+
+ * UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
+ (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
+ (-[WKFullScreenWindowController _completedExitFullScreen]):
+
+2018-06-02 Jeremy Jones <[email protected]>
+
Exit fullscreen when _javascript_ alerts are presented.
https://bugs.webkit.org/show_bug.cgi?id=185619
rdar://problem/35724264
Modified: trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm (232437 => 232438)
--- trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm 2018-06-02 16:02:14 UTC (rev 232437)
+++ trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm 2018-06-02 16:03:31 UTC (rev 232438)
@@ -541,6 +541,7 @@
auto* page = [self._webView _page];
auto* manager = self._manager;
if (page && manager) {
+ [self._webView becomeFirstResponder];
manager->didEnterFullScreen();
manager->setAnimatingFullScreen(false);
page->setSuppressVisibilityUpdates(false);
@@ -624,6 +625,7 @@
[webView setAutoresizingMask:[_webViewPlaceholder autoresizingMask]];
[[webView window] makeKeyAndVisible];
+ [webView becomeFirstResponder];
_viewState.applyTo(webView.get());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
