Modified: trunk/Source/WebCore/ChangeLog (101183 => 101184)
--- trunk/Source/WebCore/ChangeLog 2011-11-25 23:34:42 UTC (rev 101183)
+++ trunk/Source/WebCore/ChangeLog 2011-11-26 00:34:33 UTC (rev 101184)
@@ -1,5 +1,19 @@
2011-11-25 Kentaro Hara <[email protected]>
+ Refactoring CodeGenerator*.pm for bug 72138
+ https://bugs.webkit.org/show_bug.cgi?id=73115
+
+ Reviewed by Adam Barth.
+
+ Tests: bindings/scripts/test/TestObj.idl
+
+ * bindings/scripts/CodeGeneratorGObject.pm: Added "1;" at the end since this perl script is loaded as a package.
+ * bindings/scripts/CodeGeneratorV8.pm: Ditto. Removed unnecessary variable names from method declarations in order to supress style check errors when a new run-bindings-tests IDL is added.
+ (GenerateHeaderCustomCall):
+ * bindings/scripts/test/V8/V8TestObj.h: Updated a run-bindings-tests result.
+
+2011-11-25 Kentaro Hara <[email protected]>
+
Implement the WebGLContextEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=72856
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (101183 => 101184)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2011-11-25 23:34:42 UTC (rev 101183)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2011-11-26 00:34:33 UTC (rev 101184)
@@ -1380,3 +1380,5 @@
$fname =~ s/_//g;
$object->WriteData($fname);
}
+
+1;
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (101183 => 101184)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-11-25 23:34:42 UTC (rev 101183)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-11-26 00:34:33 UTC (rev 101184)
@@ -395,13 +395,13 @@
if ($attrExt->{"V8CustomGetter"} || $attrExt->{"CustomGetter"}
|| $attrExt->{"V8Custom"} || $attrExt->{"Custom"}) {
push(@headerContent, <<END);
- static v8::Handle<v8::Value> ${name}AccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info);
+ static v8::Handle<v8::Value> ${name}AccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo&);
END
}
if ($attrExt->{"V8CustomSetter"} || $attrExt->{"CustomSetter"}
|| $attrExt->{"V8Custom"} || $attrExt->{"Custom"}) {
push(@headerContent, <<END);
- static void ${name}AccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info);
+ static void ${name}AccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value>, const v8::AccessorInfo&);
END
}
if ($attrExt->{"EnabledAtRuntime"}) {
@@ -639,13 +639,13 @@
push(@headerContent, " static v8::Handle<v8::Value> callAsFunctionCallback(const v8::Arguments&);\n");
}
if ($dataNode->name eq "Event") {
- push(@headerContent, " static v8::Handle<v8::Value> dataTransferAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info);\n");
- push(@headerContent, " static void valueAccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info);\n");
+ push(@headerContent, " static v8::Handle<v8::Value> dataTransferAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo&);\n");
+ push(@headerContent, " static void valueAccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value>, const v8::AccessorInfo&);\n");
}
if ($dataNode->name eq "Location") {
- push(@headerContent, " static v8::Handle<v8::Value> assignAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info);\n");
- push(@headerContent, " static v8::Handle<v8::Value> reloadAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info);\n");
- push(@headerContent, " static v8::Handle<v8::Value> replaceAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info);\n");
+ push(@headerContent, " static v8::Handle<v8::Value> assignAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo&);\n");
+ push(@headerContent, " static v8::Handle<v8::Value> reloadAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo&);\n");
+ push(@headerContent, " static v8::Handle<v8::Value> replaceAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo&);\n");
}
}
@@ -3823,3 +3823,5 @@
print $output;
print "\n";
}
+
+1;
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h (101183 => 101184)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h 2011-11-25 23:34:42 UTC (rev 101183)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h 2011-11-26 00:34:33 UTC (rev 101184)
@@ -46,8 +46,8 @@
static v8::Handle<v8::Value> customMethodCallback(const v8::Arguments&);
static v8::Handle<v8::Value> customMethodWithArgsCallback(const v8::Arguments&);
static v8::Handle<v8::Value> constructorCallback(const v8::Arguments&);
- static v8::Handle<v8::Value> customAttrAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info);
- static void customAttrAccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info);
+ static v8::Handle<v8::Value> customAttrAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo&);
+ static void customAttrAccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value>, const v8::AccessorInfo&);
static const int internalFieldCount = v8DefaultWrapperInternalFieldCount + 0;
static v8::Handle<v8::Object> existingWrapper(TestObj*);
