Title: [232546] trunk/Source/WebCore
- Revision
- 232546
- Author
- [email protected]
- Date
- 2018-06-06 09:42:05 -0700 (Wed, 06 Jun 2018)
Log Message
Wrong NSVisualEffectMaterial used for exit full screen overlay in dark mode.
https://bugs.webkit.org/show_bug.cgi?id=186350
rdar://problem/39135535
Reviewed by Anders Carlsson.
* platform/mac/WebCoreFullScreenPlaceholderView.mm:
(-[WebCoreFullScreenPlaceholderView initWithFrame:]):
Use the NSVisualEffectMaterialFullScreenUI on macOS 10.14 and don't
set an explicit NSAppearance.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (232545 => 232546)
--- trunk/Source/WebCore/ChangeLog 2018-06-06 16:36:12 UTC (rev 232545)
+++ trunk/Source/WebCore/ChangeLog 2018-06-06 16:42:05 UTC (rev 232546)
@@ -1,3 +1,17 @@
+2018-06-06 Timothy Hatcher <[email protected]>
+
+ Wrong NSVisualEffectMaterial used for exit full screen overlay in dark mode.
+
+ https://bugs.webkit.org/show_bug.cgi?id=186350
+ rdar://problem/39135535
+
+ Reviewed by Anders Carlsson.
+
+ * platform/mac/WebCoreFullScreenPlaceholderView.mm:
+ (-[WebCoreFullScreenPlaceholderView initWithFrame:]):
+ Use the NSVisualEffectMaterialFullScreenUI on macOS 10.14 and don't
+ set an explicit NSAppearance.
+
2018-06-06 Jer Noble <[email protected]>
Regions outside of the fullscreen window are exposed during zoom operations
Modified: trunk/Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm (232545 => 232546)
--- trunk/Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm 2018-06-06 16:36:12 UTC (rev 232545)
+++ trunk/Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm 2018-06-06 16:42:05 UTC (rev 232546)
@@ -55,9 +55,15 @@
_effectView.get().autoresizingMask = NSViewWidthSizable | NSViewHeightSizable;
_effectView.get().blendingMode = NSVisualEffectBlendingModeWithinWindow;
_effectView.get().hidden = YES;
+ _effectView.get().state = NSVisualEffectStateActive;
+
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
+ _effectView.get().material = NSVisualEffectMaterialPopover;
+#else
_effectView.get().material = NSVisualEffectMaterialLight;
- _effectView.get().state = NSVisualEffectStateActive;
_effectView.get().appearance = [NSAppearance appearanceNamed:NSAppearanceNameVibrantLight];
+#endif
+
[self addSubview:_effectView.get()];
_exitWarning = adoptNS([[NSTextField alloc] initWithFrame:NSZeroRect]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
