Title: [232548] trunk/Source/WebKit
- Revision
- 232548
- Author
- [email protected]
- Date
- 2018-06-06 11:02:02 -0700 (Wed, 06 Jun 2018)
Log Message
REGRESSION (r232301) - Unable to enter video fullscreen
https://bugs.webkit.org/show_bug.cgi?id=186357
<rdar://problem/40838449>
Reviewed by Jon Lee.
Only set up the standby fullscreen element if we are in element fullscreen.
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::videoControlsManagerDidChange):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (232547 => 232548)
--- trunk/Source/WebKit/ChangeLog 2018-06-06 17:40:42 UTC (rev 232547)
+++ trunk/Source/WebKit/ChangeLog 2018-06-06 18:02:02 UTC (rev 232548)
@@ -1,3 +1,16 @@
+2018-06-06 Jer Noble <[email protected]>
+
+ REGRESSION (r232301) - Unable to enter video fullscreen
+ https://bugs.webkit.org/show_bug.cgi?id=186357
+ <rdar://problem/40838449>
+
+ Reviewed by Jon Lee.
+
+ Only set up the standby fullscreen element if we are in element fullscreen.
+
+ * WebProcess/FullScreen/WebFullScreenManager.cpp:
+ (WebKit::WebFullScreenManager::videoControlsManagerDidChange):
+
2018-06-06 Jeremy Jones <[email protected]>
attenuationFactor should be in range [0,1]
Modified: trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp (232547 => 232548)
--- trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp 2018-06-06 17:40:42 UTC (rev 232547)
+++ trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp 2018-06-06 18:02:02 UTC (rev 232548)
@@ -89,7 +89,12 @@
{
#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
auto* currentPlaybackControlsElement = m_page->playbackSessionManager().currentPlaybackControlsElement();
- setPIPStandbyElement(is<HTMLVideoElement>(currentPlaybackControlsElement) ? downcast<HTMLVideoElement>(currentPlaybackControlsElement) : nullptr);
+ if (!m_element || !is<HTMLVideoElement>(currentPlaybackControlsElement)) {
+ setPIPStandbyElement(nullptr);
+ return;
+ }
+
+ setPIPStandbyElement(downcast<HTMLVideoElement>(currentPlaybackControlsElement));
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
