Title: [232557] trunk
- Revision
- 232557
- Author
- [email protected]
- Date
- 2018-06-06 13:37:23 -0700 (Wed, 06 Jun 2018)
Log Message
REGRESSION (r231817?): Layout Test media/track/track-delete-during-setup.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=185889
<rdar://problem/40583180>
Reviewed by Eric Carlson.
Source/WebCore:
Explicitly update the network and ready states when detaching the AVPlayerItem
from the AVPlayer.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldBufferData):
LayoutTests:
Modify the track-delete-during-setup.html test to end on video element suspend in
addition to canplaythrough.
* media/track/track-delete-during-setup.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (232556 => 232557)
--- trunk/LayoutTests/ChangeLog 2018-06-06 20:13:43 UTC (rev 232556)
+++ trunk/LayoutTests/ChangeLog 2018-06-06 20:37:23 UTC (rev 232557)
@@ -1,5 +1,18 @@
2018-06-06 Jer Noble <[email protected]>
+ REGRESSION (r231817?): Layout Test media/track/track-delete-during-setup.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=185889
+ <rdar://problem/40583180>
+
+ Reviewed by Eric Carlson.
+
+ Modify the track-delete-during-setup.html test to end on video element suspend in
+ addition to canplaythrough.
+
+ * media/track/track-delete-during-setup.html:
+
+2018-06-06 Jer Noble <[email protected]>
+
Regions outside of the fullscreen window are exposed during zoom operations
https://bugs.webkit.org/show_bug.cgi?id=186330
<rdar://problem/34698009>
Modified: trunk/LayoutTests/media/track/track-delete-during-setup.html (232556 => 232557)
--- trunk/LayoutTests/media/track/track-delete-during-setup.html 2018-06-06 20:13:43 UTC (rev 232556)
+++ trunk/LayoutTests/media/track/track-delete-during-setup.html 2018-06-06 20:37:23 UTC (rev 232557)
@@ -23,6 +23,11 @@
setTimeout("endTest()", 100);
}
+ function suspend()
+ {
+ setTimeout("endTest()", 100);
+ }
+
function start()
{
consoleWrite("<feOffset>");
@@ -37,5 +42,5 @@
}
</script>
<body _onload_="start()">
-<command><aside><kbd><video _oncanplaythrough_="canplaythrough()" >
+<command><aside><kbd><video _oncanplaythrough_="canplaythrough()" _onsuspend_="suspend()">
<track src="" _onload_="metadataTrackLoaded()">
Modified: trunk/Source/WebCore/ChangeLog (232556 => 232557)
--- trunk/Source/WebCore/ChangeLog 2018-06-06 20:13:43 UTC (rev 232556)
+++ trunk/Source/WebCore/ChangeLog 2018-06-06 20:37:23 UTC (rev 232557)
@@ -1,3 +1,17 @@
+2018-06-06 Jer Noble <[email protected]>
+
+ REGRESSION (r231817?): Layout Test media/track/track-delete-during-setup.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=185889
+ <rdar://problem/40583180>
+
+ Reviewed by Eric Carlson.
+
+ Explicitly update the network and ready states when detaching the AVPlayerItem
+ from the AVPlayer.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldBufferData):
+
2018-06-06 Antoine Quint <[email protected]>
Use the default label for snapshotted plug-ins if no mime-type is available
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (232556 => 232557)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2018-06-06 20:13:43 UTC (rev 232556)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2018-06-06 20:37:23 UTC (rev 232557)
@@ -3057,6 +3057,7 @@
return;
setAVPlayerItem(shouldBuffer ? m_avPlayerItem.get() : nil);
+ updateStates();
}
#if ENABLE(DATACUE_VALUE)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
