Title: [232593] trunk/Tools
- Revision
- 232593
- Author
- [email protected]
- Date
- 2018-06-07 12:17:39 -0700 (Thu, 07 Jun 2018)
Log Message
REGRESSION (r232544): [iOS] TestWebKitAPI.WebKit.OverrideLayoutSizeChangesDuringAnimatedResizeSucceed is failing
https://bugs.webkit.org/show_bug.cgi?id=186395
<rdar://problem/40902427>
Reviewed by Wenson Hsieh.
* TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
(TEST):
endAnimatedResize no longer synchronizes, so we have to wait for the next presentation update.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (232592 => 232593)
--- trunk/Tools/ChangeLog 2018-06-07 18:47:26 UTC (rev 232592)
+++ trunk/Tools/ChangeLog 2018-06-07 19:17:39 UTC (rev 232593)
@@ -1,3 +1,15 @@
+2018-06-07 Tim Horton <[email protected]>
+
+ REGRESSION (r232544): [iOS] TestWebKitAPI.WebKit.OverrideLayoutSizeChangesDuringAnimatedResizeSucceed is failing
+ https://bugs.webkit.org/show_bug.cgi?id=186395
+ <rdar://problem/40902427>
+
+ Reviewed by Wenson Hsieh.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
+ (TEST):
+ endAnimatedResize no longer synchronizes, so we have to wait for the next presentation update.
+
2018-06-07 Thibault Saunier <[email protected]>
[GTK][WPE] Start implementing MediaStream API
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm (232592 => 232593)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm 2018-06-07 18:47:26 UTC (rev 232592)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm 2018-06-07 19:17:39 UTC (rev 232593)
@@ -208,15 +208,19 @@
[webView _endAnimatedResize];
__block bool didReadLayoutSize = false;
- [webView evaluateJavaScript:@"[window.innerWidth, window.innerHeight]" completionHandler:^(id value, NSError *error) {
- CGFloat innerWidth = [[value objectAtIndex:0] floatValue];
- CGFloat innerHeight = [[value objectAtIndex:1] floatValue];
- EXPECT_EQ(innerWidth, 100);
- EXPECT_EQ(innerHeight, 200);
+ [webView _doAfterNextPresentationUpdate:^{
+ [webView evaluateJavaScript:@"[window.innerWidth, window.innerHeight]" completionHandler:^(id value, NSError *error) {
+ CGFloat innerWidth = [[value objectAtIndex:0] floatValue];
+ CGFloat innerHeight = [[value objectAtIndex:1] floatValue];
- didReadLayoutSize = true;
+ EXPECT_EQ(innerWidth, 100);
+ EXPECT_EQ(innerHeight, 200);
+
+ didReadLayoutSize = true;
+ }];
}];
+
TestWebKitAPI::Util::run(&didReadLayoutSize);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
