Title: [232595] trunk/Source/WebKit
- Revision
- 232595
- Author
- [email protected]
- Date
- 2018-06-07 12:48:48 -0700 (Thu, 07 Jun 2018)
Log Message
Use the same overloaded addInputString in WKContentViewInteraction
https://bugs.webkit.org/show_bug.cgi?id=186376
<rdar://problem/18498360>
Reviewed by Brent Fulgham.
Different overloaded variants of [UIKeyboardImpl -addInputString] behaves differently. We should use the same
overloaded variant consistently: [UIKeyboardImpl -addInputString:withFlags:withInputManagerHint:].
Sadly, there is no test case for this change as:
1) UIScriptController has troubles simulating '\r' keyboard event, and
2) API test couldn't simulate proper UI keyboard events.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _interpretKeyEvent:isCharEvent:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (232594 => 232595)
--- trunk/Source/WebKit/ChangeLog 2018-06-07 19:19:31 UTC (rev 232594)
+++ trunk/Source/WebKit/ChangeLog 2018-06-07 19:48:48 UTC (rev 232595)
@@ -1,3 +1,21 @@
+2018-06-07 Jiewen Tan <[email protected]>
+
+ Use the same overloaded addInputString in WKContentViewInteraction
+ https://bugs.webkit.org/show_bug.cgi?id=186376
+ <rdar://problem/18498360>
+
+ Reviewed by Brent Fulgham.
+
+ Different overloaded variants of [UIKeyboardImpl -addInputString] behaves differently. We should use the same
+ overloaded variant consistently: [UIKeyboardImpl -addInputString:withFlags:withInputManagerHint:].
+
+ Sadly, there is no test case for this change as:
+ 1) UIScriptController has troubles simulating '\r' keyboard event, and
+ 2) API test couldn't simulate proper UI keyboard events.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView _interpretKeyEvent:isCharEvent:]):
+
2018-06-07 Alex Christensen <[email protected]>
REGRESSION(r224134) Client certificate challenges don't always appear
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (232594 => 232595)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-06-07 19:19:31 UTC (rev 232594)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-06-07 19:48:48 UTC (rev 232595)
@@ -3742,7 +3742,7 @@
case kWebReturnKey:
if (contentEditable && isCharEvent) {
// Map \r from HW keyboard to \n to match the behavior of the soft keyboard.
- [keyboard addInputString:@"\n" withFlags:0];
+ [keyboard addInputString:@"\n" withFlags:0 withInputManagerHint:nil];
return YES;
}
break;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
