Title: [232606] trunk/Source/WebKit
- Revision
- 232606
- Author
- [email protected]
- Date
- 2018-06-07 16:20:28 -0700 (Thu, 07 Jun 2018)
Log Message
Match HI spec for thumbnail view sizing and location
https://bugs.webkit.org/show_bug.cgi?id=186412
<rdar://problem/40226192>
Reviewed by Tim Horton.
Use the computed obscured inset to position the QuickLook
view inside the WKSystemPreviewView.
* UIProcess/ios/WKSystemPreviewView.mm:
(-[WKSystemPreviewView web_setContentProviderData:suggestedFilename:]):
(-[WKSystemPreviewView _layoutThumbnailView]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (232605 => 232606)
--- trunk/Source/WebKit/ChangeLog 2018-06-07 23:15:41 UTC (rev 232605)
+++ trunk/Source/WebKit/ChangeLog 2018-06-07 23:20:28 UTC (rev 232606)
@@ -1,3 +1,18 @@
+2018-06-07 Dean Jackson <[email protected]>
+
+ Match HI spec for thumbnail view sizing and location
+ https://bugs.webkit.org/show_bug.cgi?id=186412
+ <rdar://problem/40226192>
+
+ Reviewed by Tim Horton.
+
+ Use the computed obscured inset to position the QuickLook
+ view inside the WKSystemPreviewView.
+
+ * UIProcess/ios/WKSystemPreviewView.mm:
+ (-[WKSystemPreviewView web_setContentProviderData:suggestedFilename:]):
+ (-[WKSystemPreviewView _layoutThumbnailView]):
+
2018-06-07 Tadeu Zagallo <[email protected]>
Don't try to allocate JIT memory if we don't have the JIT entitlement
Modified: trunk/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm (232605 => 232606)
--- trunk/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm 2018-06-07 23:15:41 UTC (rev 232605)
+++ trunk/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm 2018-06-07 23:20:28 UTC (rev 232606)
@@ -128,7 +128,13 @@
{
if (_thumbnailView) {
UIEdgeInsets safeAreaInsets = _webView._computedUnobscuredSafeAreaInset;
- CGRect layoutFrame = CGRectMake(0, 0, self.frame.size.width - safeAreaInsets.left - safeAreaInsets.right, self.frame.size.height - safeAreaInsets.top - safeAreaInsets.bottom);
+ UIEdgeInsets obscuredAreaInsets = _webView._computedObscuredInset;
+
+ CGRect layoutFrame = UIEdgeInsetsInsetRect(self.frame, safeAreaInsets);
+
+ layoutFrame.size.width -= obscuredAreaInsets.left + obscuredAreaInsets.right;
+ layoutFrame.size.height -= obscuredAreaInsets.top + obscuredAreaInsets.bottom;
+
[_thumbnailView setFrame:layoutFrame];
[_thumbnailView setAutoresizingMask:UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight];
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
